Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve BuWizz 3.0 communication reliability #119

Open
BrickExperimentChannel opened this issue Aug 2, 2024 · 1 comment
Open

Improve BuWizz 3.0 communication reliability #119

BrickExperimentChannel opened this issue Aug 2, 2024 · 1 comment

Comments

@BrickExperimentChannel
Copy link

I have a suggestion on how to improve the BuWizz 3.0 communication reliability.

Re-send the last message after 200 ms of inactivity, then re-send it again after 600 ms of inactivity.
I've tested this improves the reliability a little.

It reduces the worst cases, where you cannot stop your Lego vehicle from driving to a wall because the communication is having a 2 second halt.

Also, I noticed that the _sendAttemptsLeft implementation you've done is never used, because the sends always succeed, even when the communication is not working.

My reference implementation in BuWizz3Device::ProcessOutputsAsync
https://www.dropbox.com/scl/fo/mr4h8oyet4d2gzv78ra3k/AAPulxX1pFI_cAGAQ5Howok?dl=0&e=1&preview=com.scn.BrickController2_source.zip&rlkey=5nmbh3femf4sto95rvriucnvn

@imurvai
Copy link
Owner

imurvai commented Aug 19, 2024

Thanks for the suggestion, I'll check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants