Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename map_dep() to map_deployments() #231

Closed
peterdesmet opened this issue Jul 13, 2023 · 2 comments · Fixed by #331
Closed

Rename map_dep() to map_deployments() #231

peterdesmet opened this issue Jul 13, 2023 · 2 comments · Fixed by #331
Assignees
@damianooldoni
Milestone
v1.0

Comments

@peterdesmet
Copy link
Member

peterdesmet commented Jul 13, 2023 •
edited
Loading

Suggested in camtraptor July 2023 coding sprint

Rationale: do not abbreviate. Some parameters should be removed as well.

map_dep(
  package = NULL,
  feature,
  # ... removed, see filter functions
  # species = NULL removed, see filter functions
  # sex = NULL  removed, see filter functions
  # life_stage = NULL  removed, see filter functions
  effort_unit = NULL, 
  cluster = TRUE,
  hover_columns = [c](https://rdrr.io/r/base/c.html)("n", "species", "deploymentID", "locationID", "locationName",
    "latitude", "longitude", "start", "end"),
  palette = "inferno",
  zero_values_show = TRUE,
  zero_values_icon_url = "https://img.icons8.com/ios-glyphs/30/000000/multiply.png",
  zero_values_icon_size = 10,
  relative_scale = TRUE,
  max_scale = NULL,
  radius_range = [c](https://rdrr.io/r/base/c.html)(10, 50),
  # datapkg removed
)
@peterdesmet peterdesmet added this to the v1.0 milestone Jul 13, 2023
@peterdesmet peterdesmet changed the title Rename functions Rename four functions Jul 13, 2023
@peterdesmet peterdesmet changed the title Rename four functions Rename some functions Jul 13, 2023
@peterdesmet peterdesmet mentioned this issue Jul 13, 2023
Closed
@peterdesmet peterdesmet changed the title Rename some functions Rename map_dep() to map_deployments() Jul 14, 2023
This was referenced Jul 24, 2023
Open
Open
damianooldoni added a commit that referenced this issue Jul 22, 2024
@damianooldoni
Fix #231
7521921
@damianooldoni damianooldoni self-assigned this Jul 22, 2024
damianooldoni added a commit that referenced this issue Jul 22, 2024
@damianooldoni
Rename map_dep() function to map_deployments()
dee8feb 
See #231.
damianooldoni added a commit that referenced this issue Jul 22, 2024
@damianooldoni
Remove filtering args in map_deployments()
86f0404 
See #231
damianooldoni added a commit that referenced this issue Jul 22, 2024
@damianooldoni
Add renaming in NEWS.md
769dad4 
#239, #231, #240, #243
damianooldoni added a commit that referenced this issue Jul 23, 2024
@damianooldoni
Remove sections about filtering by species and life stage
2d631fc 
Filtering will be discussed in a specific vignette, see #320.
Removing filtering is also needed as the function will not support anymore these args as discussed in #231.
@damianooldoni
Copy link
Member

About deprecating/removing old function and removing sex and life stage arguments: see #237 (comment)

@damianooldoni damianooldoni mentioned this issue Jul 25, 2024
Merged
@sannegovaert sannegovaert linked a pull request Aug 1, 2024 that will close this issue
Use filter functions/remove args from functions #331
Merged
@damianooldoni
Copy link
Member

Fixed by #331

@damianooldoni damianooldoni mentioned this issue Oct 30, 2024
Open
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damianooldoni damianooldoni

Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

Use filter functions/remove args from functions inbo/camtraptor
2 participants
@peterdesmet @damianooldoni