Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename get_n_species() to n_species() #243

Closed
peterdesmet opened this issue Jul 14, 2023 · 2 comments
Closed

Rename get_n_species() to n_species() #243

peterdesmet opened this issue Jul 14, 2023 · 2 comments
Milestone
v1.0

Comments

@peterdesmet
Copy link
Member

Suggested in camtraptor July 2023 coding sprint

Rationale: consistency. Some parameters should be removed as well

n_species(
  package = NULL,
  group_by = "deploymentID" # new param, not sure if other groups make sense
  # ... removed, see filters
  # datapkg removed
)

The returned information would be:

deploymentID
n_species # currently n
@peterdesmet peterdesmet added this to the v1.0 milestone Jul 14, 2023
@peterdesmet peterdesmet changed the title Rename get_n_species() to n_species Rename get_n_species() to n_species() Jul 15, 2023
damianooldoni added a commit that referenced this issue Jul 22, 2024
@damianooldoni
Rename get_n_species as n_species
ffeb6cc 
Fix #243.
damianooldoni added a commit that referenced this issue Jul 22, 2024
@damianooldoni
Add renaming in NEWS.md
769dad4 
#239, #231, #240, #243
@damianooldoni damianooldoni mentioned this issue Jul 24, 2024
Open
@damianooldoni
Copy link
Member

About deprecating vs removing old function: see #237 (comment)

@damianooldoni damianooldoni mentioned this issue Jul 25, 2024
Merged
@damianooldoni
Copy link
Member

Solved by PR #331.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
2 participants
@peterdesmet @damianooldoni