Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to group by deployment characteristics #280

Open
damianooldoni opened this issue Sep 26, 2023 · 0 comments
Open

Add possibility to group by deployment characteristics #280

damianooldoni opened this issue Sep 26, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@damianooldoni
Copy link
Member

damianooldoni commented Sep 26, 2023

Feature request from @jimcasaer: it's useful sometimes to have effort grouped by deployment characteristics, not only by time periods.

Two alternatives are possible. get_custom_effort() would:

  • accept multiple values (vector) for group_by argument: get_custom_effort(mica, group_by = c("day", "locationName")), OR
  • add a group_by_feature argument (default value: NULL): get_custom_effort(mica, group_by = "day", group_by_feature = "locationName")

Possible values for these extra grouping are: locationName, tag or a custom column in dp$data$deployment. In other words, all columns characterizing the deployments.

Based on #236, we should opt for first option. In that issue we opted to add an extra value for group_by: deploymentID. This will allow us to merge the two functions, get_custom_effort() and get_effort().

So, this issue is an addition to #236 to allow multiple values for grouping.

@damianooldoni damianooldoni added the enhancement New feature or request label Sep 26, 2023
@damianooldoni damianooldoni added this to the v1.0 milestone Sep 26, 2023
@damianooldoni damianooldoni self-assigned this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant