Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving error visibility #120

Open
Bruno-DaSilva opened this issue Jun 7, 2023 · 1 comment
Open

Improving error visibility #120

Bruno-DaSilva opened this issue Jun 7, 2023 · 1 comment

Comments

@Bruno-DaSilva
Copy link

Hi @nikordaris :)

Thanks for the work on this. In trying to set this up on my own repos, I ran into some configuration issues that I had to debug. In the current implementation, the workflow shows green with no errors logged even when there are, say, 401/403s in the exporter.

I managed to get 1. error logging and 2. job failure on otel errors working for myself and thought I'd give back in an MR :)

See: #119

@nikordaris
Copy link
Contributor

I responded on the PR, I think this is a great improvement opportunity!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants