Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for HTTPS tracing protocol #194

Open
danielloader opened this issue Dec 31, 2023 · 4 comments
Open

Support for HTTPS tracing protocol #194

danielloader opened this issue Dec 31, 2023 · 4 comments

Comments

@danielloader
Copy link

danielloader commented Dec 31, 2023

It looks from glancing at the source this action only supports gRPC for the OTEL traces, can I confirm this is correct?

Looks that you'd need to import/use https://www.npmjs.com/package/@opentelemetry/exporter-trace-otlp-proto conditionally based on the environment variable for the protocol, or pickup and guess from the endpoint protocol prefix in the URI.

Was trying to use the action with grafana cloud but they haven't got gRPC support yet for ingesting OTEL tracing spans and as expected if the above assumption is true then it's an expected failure.

      - name: Export Workflow Trace
        uses: inception-health/otel-export-trace-action@latest
        env: 
          OTEL_EXPORTER_OTLP_PROTOCOL: http/protobuf
        with:
          otlpEndpoint: https://otlp-gateway-prod-eu-west-2.grafana.net/otlp
          otlpHeaders: "Authorization=Basic ${{ secrets.OLTP_ACTIONS_TRACES_HEADER }}"
          githubToken: ${{ secrets.GITHUB_TOKEN }}
          runId: ${{ github.event.workflow_run.id }}

Source: https://grafana.com/docs/grafana-cloud/send-data/otlp/send-data-otlp/#push-directly-from-applications-using-the-opentelemetry-sdks

https://opentelemetry.io/docs/concepts/sdk-configuration/otlp-exporter-configuration/#otel_exporter_otlp_traces_protocol

@gerhard
Copy link

gerhard commented Jan 24, 2024

I was looking at doing exactly the same thing @danielloader.

Did you manage to make progress with this?

@corentinmusard
Copy link

corentinmusard commented Feb 8, 2024

I'll want to use http as well, any update?

@corentinmusard
Copy link

Hi!
@gerhard @danielloader

Because this repo looks unmaintained I added support for https in my fork corentinmusard/otel-cicd-action.

I plan to maintain and release more features on my fork, feel free to use it.

If you want to give it a try, you just have to replace the action name:

uses: corentinmusard/otel-cicd-action@v1

Please tell me if it's not working as intended 🙂

@gerhard
Copy link

gerhard commented Jun 10, 2024

Thank you @corentinmusard! Using your fork in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants