Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node 16 actions are deprecated #196

Open
nicholascapo opened this issue Jan 25, 2024 · 2 comments
Open

Node 16 actions are deprecated #196

nicholascapo opened this issue Jan 25, 2024 · 2 comments

Comments

@nicholascapo
Copy link

nicholascapo commented Jan 25, 2024 •
edited
Loading

Warning from a recent run:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: inception-health/otel-export-trace-action@latest. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
@nicholascapo nicholascapo changed the title Node 18 is deprecated Node 16 actions are deprecated Jan 25, 2024
@bigdogwillfeed
Copy link

From what I've seen in other actions, I believe the only change might be updating action.yaml with

runs:
  using: 'node20'

but I haven't looked any further.

Love the action and we've gotten lots of use out of it!

nicholascapo added a commit to nicholascapo/otel-export-trace-action that referenced this issue Feb 2, 2024
@nicholascapo
feat: Upgrade to node 20
d062f30 
* Update to actions/checkout@v4
* Update to actions/setup-node@v4
* Set engines config in package.json
* Use node-version-file option for actions/setup-node
* Configure action to run using node20
* Fixes: inception-health#196

Signed-off-by: Nicholas Capo <[email protected]>
@nicholascapo nicholascapo mentioned this issue Feb 2, 2024
Closed
@nicholascapo
Copy link
Author

@bigdogwillfeed thanks for the hint that it would be easy...it was easy 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Upgrade to node 20 nicholascapo/otel-export-trace-action
2 participants
@nicholascapo @bigdogwillfeed