feat: Upgrade to node 20 #197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholascapo
commented
Feb 2, 2024
nicholascapo
commented
- Update to actions/checkout@v4
- Update to actions/setup-node@v4
- Set engines config in package.json
- Use node-version-file option for actions/setup-node
- Configure action to run using node20
- Fixes: Node 16 actions are deprecated #196
* Update to actions/checkout@v4 * Update to actions/setup-node@v4 * Set engines config in package.json * Use node-version-file option for actions/setup-node * Configure action to run using node20 * Fixes: inception-health#196 Signed-off-by: Nicholas Capo <[email protected]>
nicholascapo
commented
Feb 2, 2024
| @@ -71,5 +71,8 @@ | |||
| "classNameTemplate": "{classname}", | |||
| "includeConsoleOutput": "true", | |||
| "reportTestSuiteErrors": "true" | |||
| }, | |||
| "engines": { | |||
| "node": "^20" | |||
There was a problem hiding this comment.
Need to confirm that this works correctly in CI.
I expect to get a node version that is >=20, <21 but not exactly 20.0.0
|
Reviews please. |
|
Is there something I can do to help move this forward? 😄 |
v1v
approved these changes
Feb 15, 2024
v1v
reviewed
Feb 19, 2024
There was a problem hiding this comment.
For the record, this is a breaking change, see hashicorp/vault-action#526.
If possible I'd say to release v2
That makes sense. |
|
@nikordaris are you able to approve this so that (at least) the CI runs? 😄 |
|
👋 Any word here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.