Fix NPE for start API with blobstore (#589)

longquanzheng · web-flow · commit 0ef67dc434a4 · 2025-08-28T21:23:35.000-07:00
diff --git a/service/api/service.go b/service/api/service.go
@@ -187,7 +187,7 @@ func (s *serviceImpl) ApiV1WorkflowStartPost(
 			return nil, s.handleError(err, WorkflowStartApiPath, req.GetWorkflowId())
 		}
 		// 1. check the size of the input is larger than the threshold
-		if len(*input.StateInput.Data) > s.config.ExternalStorage.ThresholdInBytes {
+		if input.StateInput != nil && len(input.StateInput.GetData()) > s.config.ExternalStorage.ThresholdInBytes {
 			// 2. if it is, upload the input to S3
 			storeId, path, err := s.store.WriteObject(ctx, req.GetWorkflowId(), input.StateInput.GetData())
 			if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ func (s *serviceImpl) ApiV1WorkflowStartPost(`
`187`	`187`	`return nil, s.handleError(err, WorkflowStartApiPath, req.GetWorkflowId())`
`188`	`188`	`}`
`189`	`189`	`// 1. check the size of the input is larger than the threshold`
`190`		`- if len(*input.StateInput.Data) > s.config.ExternalStorage.ThresholdInBytes {`
	`190`	`+ if input.StateInput != nil && len(input.StateInput.GetData()) > s.config.ExternalStorage.ThresholdInBytes {`
`191`	`191`	`// 2. if it is, upload the input to S3`
`192`	`192`	`storeId, path, err := s.store.WriteObject(ctx, req.GetWorkflowId(), input.StateInput.GetData())`
`193`	`193`	`if err != nil {`