Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider opening the API #27

Open
xrstf opened this issue Aug 22, 2012 · 0 comments
Open

Consider opening the API #27

xrstf opened this issue Aug 22, 2012 · 0 comments

Comments

@xrstf
Copy link
Contributor

xrstf commented Aug 22, 2012

I'm trying to work around issue #23. For this, I tried to simply use a custom storage implementation that has my patch (LOCK_SH) in it.

Unfortunately, nearly everything inside the Session middleware is private, so for making a simple patch to lock() I have to copy nearly everything. Not just because most of the stuff is private, but because most methods directly access the properties (instead of using a getter).

This makes it extremely hard and ugly to subclass AiP. I would suggest using protected more often and/or introducing some getters where properties must be private.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant