Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency: When initializing a class or calling a method with both an ideal and a nadir value, the ideal value should always preceed the nadir value #23

Open
gialmisi opened this issue Aug 6, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@gialmisi
Copy link
Contributor

gialmisi commented Aug 6, 2021

At the moment, in some places, where calling a method or initializing a class is done using both an ideal and a nadir value, the order of the values in the call signature varies. I.e., sometimes the nadir is first and sometimes the ideal. This can, and has, led to annoying bugs. Therefore, it should be fixed.

For example, instances with

def foo(nadir, ideal, ...):
    ...

should be changed to

def foo(ideal, nadir, ...):
    ...

This is an easy fix. I am documenting it here so somebody can address it in due time.

@gialmisi gialmisi added enhancement New feature or request good first issue Good for newcomers labels Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant