Made _copy_variable function

Author: dnguyen227

src/constraints.jl

@@ -23,6 +23,32 @@ _vec_to_scalar_set(::_MOIExactly) = _MOI.EqualTo
 _vec_to_scalar_set(::_MOIAtLeast) = _MOI.GreaterThan
 _vec_to_scalar_set(::_MOIAtMost) = _MOI.LessThan
 
+#helper function to create variables
+# Helper function to copy variable properties from an existing variable
+function _copy_variable(
+    target_model::JuMP.AbstractModel,
+    original_var::JuMP.AbstractVariableRef,
+    )
+    # Create new variable
+    new_var = JuMP.@variable(target_model, base_name = JuMP.name(original_var))
+    
+    # Copy all properties from original variable
+    JuMP.has_lower_bound(original_var) && JuMP.set_lower_bound(new_var, JuMP.lower_bound(original_var))
+    JuMP.has_upper_bound(original_var) && JuMP.set_upper_bound(new_var, JuMP.upper_bound(original_var))
+    JuMP.has_start_value(original_var) && JuMP.set_start_value(new_var, JuMP.start_value(original_var))
+    JuMP.is_integer(original_var) && JuMP.set_integer(new_var)
+    JuMP.is_binary(original_var) && JuMP.set_binary(new_var)
+    
+    # Handle fixed values with force=true (as in original MBM code)
+    if JuMP.is_fixed(original_var)
+        JuMP.fix(new_var, JuMP.fix_value(original_var); force=true)
+    end
+    
+    return new_var
+end
+
+
+
 ################################################################################
 #                         BOILERPLATE EXTENSION METHODS
 ################################################################################

src/mbm.jl

@@ -150,7 +150,7 @@ function reformulate_disjunct_constraint(
     ::Dict{LogicalVariableRef,Float64}, 
     ::MBM
 ) where {F}
-    error("Constraint type $(typeof(con)) is not supported by the Multiple Big-M reformulation method.")
+    error("Constraint type $(typeof(F)) is not supported by the Multiple Big-M reformulation method.")
 end
 
 ################################################################################
@@ -227,22 +227,7 @@ function _mini_model(
     sub_model = JuMP.Model()
     new_vars = Dict{JuMP.AbstractVariableRef, JuMP.AbstractVariableRef}()
     for var in JuMP.all_variables(model)
-        new_vars[var] = JuMP.@variable(sub_model, base_name= "sub_model_$(JuMP.name(var))")
-        if JuMP.is_fixed(var)
-            JuMP.fix(new_vars[var], JuMP.fix_value(var); force=true)
-        end
-        if JuMP.is_integer(var)
-            JuMP.set_integer(new_vars[var])
-        end
-        if JuMP.has_upper_bound(var)
-            JuMP.set_upper_bound(new_vars[var], JuMP.upper_bound(var))
-        end
-        if JuMP.has_lower_bound(var)
-            JuMP.set_lower_bound(new_vars[var], JuMP.lower_bound(var))
-        end
-        if JuMP.has_start_value(var)
-            JuMP.set_start_value(new_vars[var], JuMP.start_value(var))
-        end
+        new_vars[var] = _copy_variable(sub_model, var)
     end
     for con in [JuMP.constraint_object(con) for con in constraints]
         expr = replace_variables_in_constraint(con.func, new_vars)

test/runtests.jl

@@ -1,22 +1,23 @@
 import DisjunctiveProgramming as DP
 using DisjunctiveProgramming
 using Test
+using Revise
 include("utilities.jl")
 
 # RUN ALL THE TESTS
-include("aqua.jl")
-include("model.jl")
-include("jump.jl")
-include("variables/query.jl")
-include("variables/logical.jl")
-include("constraints/selector.jl")
-include("constraints/proposition.jl")
-include("constraints/disjunct.jl")
-include("constraints/indicator.jl")
-include("constraints/bigm.jl")
-include("constraints/hull.jl")
-include("constraints/fallback.jl")
-include("constraints/disjunction.jl")
-include("print.jl")
-include("solve.jl")
+# include("aqua.jl")
+# include("model.jl")
+# include("jump.jl")
+# include("variables/query.jl")
+# include("variables/logical.jl")
+# include("constraints/selector.jl")
+# include("constraints/proposition.jl")
+# include("constraints/disjunct.jl")
+# include("constraints/indicator.jl")
+# include("constraints/bigm.jl")
+# include("constraints/hull.jl")
+# include("constraints/fallback.jl")
+# include("constraints/disjunction.jl")
+# include("print.jl")
+# include("solve.jl")
 include("constraints/mbm.jl")