Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inputs.gnmi): Handle YANG namespaces in paths correctly #15565

Merged
merged 1 commit into from
Jun 28, 2024
Merged

fix(inputs.gnmi): Handle YANG namespaces in paths correctly #15565

merged 1 commit into from
Jun 28, 2024

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Jun 25, 2024

Summary

The current code fails to resolve aliases for cases where the subscription update contains YANG-model namespaces in path elements. This PR explicitly handles the namespace elements the right way.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15546

@telegraf-tiger telegraf-tiger bot added area/gnmi fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jun 25, 2024
@srebhan srebhan mentioned this pull request Jun 25, 2024
Closed
@srebhan srebhan self-assigned this Jun 25, 2024
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 28, 2024
@srebhan srebhan assigned powersj and DStrand1 and unassigned srebhan Jun 28, 2024
@powersj powersj removed their assignment Jun 28, 2024
@DStrand1 DStrand1 merged commit 1b849eb into influxdata:master Jun 28, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.31.1 milestone Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@DStrand1 DStrand1 DStrand1 approved these changes

Assignees

@DStrand1 DStrand1

Labels
area/gnmi fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.31.1
Development

Successfully merging this pull request may close these issues.

gNMI got empty metric name for response
3 participants
@srebhan @powersj @DStrand1