Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document CometMock/CometBFT differences/deficiencies #61

Open
p-offtermatt opened this issue Sep 25, 2023 · 1 comment
Open

Document CometMock/CometBFT differences/deficiencies #61

p-offtermatt opened this issue Sep 25, 2023 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@p-offtermatt
Copy link
Member

There should be documentation for the deficiencies where CometMock does not replicate the behaviour of CometBFT (yet).
For example, a folder with Markdown documentation.

@p-offtermatt p-offtermatt self-assigned this Sep 25, 2023
@p-offtermatt p-offtermatt added the documentation Improvements or additions to documentation label Sep 25, 2023
@p-offtermatt
Copy link
Member Author

p-offtermatt commented Oct 4, 2023

v0.38:

  • The POL Round is hardcoded to 0 when creating a new proposal TODO: link
  • sendInternalMessage is not called when making a proposal
  • The timeout in the context when subscribing to a websocket is fixed manually
  • closeIfSlow is manually set to false
  • We do not submit actual evidence - we just submit bare minimum evidence to tell the application someone misbehaved, but double-checking the actual evidence might not work
  • For RequestPrepareProposal, use maxDataBytes = -1 (unlimited) since we have no mempool anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant