From 869d15306141b13b455efbdde6686cc2648ee1d8 Mon Sep 17 00:00:00 2001 From: Farhad Shabani Date: Wed, 29 Jan 2025 09:43:05 -0800 Subject: [PATCH] nit: few typos --- .../v0.49.1/breaking-changes/1014-better-client-id-new.md | 4 ++-- .../breaking-changes/839-add-memo-field-for-token-escrow.md | 3 +-- CHANGELOG.md | 2 +- docs/architecture/adr-001-handler-implementation.md | 2 +- docs/architecture/adr-007-light-client-contexts.md | 2 +- 5 files changed, 6 insertions(+), 7 deletions(-) diff --git a/.changelog/v0.49.1/breaking-changes/1014-better-client-id-new.md b/.changelog/v0.49.1/breaking-changes/1014-better-client-id-new.md index 2c7ad406e7..af418d31a7 100644 --- a/.changelog/v0.49.1/breaking-changes/1014-better-client-id-new.md +++ b/.changelog/v0.49.1/breaking-changes/1014-better-client-id-new.md @@ -1,4 +1,4 @@ -- `[ibc-core-host-types]` Introduce `ClientType::build_client_id` which avoids unnecessary validaiton. +- `[ibc-core-host-types]` Introduce `ClientType::build_client_id` which avoids unnecessary validation. ([#1014](https://github.com/cosmos/ibc-rs/issues/1014)) -- `[ibc-core-host-types]` Optimise `ClientId::new` to avoid unnecessary validaiton and temporary +- `[ibc-core-host-types]` Optimise `ClientId::new` to avoid unnecessary validation and temporary string allocation. ([#1014](https://github.com/cosmos/ibc-rs/issues/1014)) diff --git a/.changelog/v0.49.1/breaking-changes/839-add-memo-field-for-token-escrow.md b/.changelog/v0.49.1/breaking-changes/839-add-memo-field-for-token-escrow.md index f506d88099..fbe66e6a36 100644 --- a/.changelog/v0.49.1/breaking-changes/839-add-memo-field-for-token-escrow.md +++ b/.changelog/v0.49.1/breaking-changes/839-add-memo-field-for-token-escrow.md @@ -1,5 +1,4 @@ - `[ibc-app-transfer]` Add `memo` field to `escrow-coins-*()` and - `burn-coins-*()` methods, allowing implementors to pass in arbitrary data + `burn-coins-*()` methods, allowing implementers to pass in arbitrary data necessary for their use case. ([\#839](https://github.com/cosmos/ibc-rs/issues/837)) - \ No newline at end of file diff --git a/CHANGELOG.md b/CHANGELOG.md index 3ddf54061b..02f61c619c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -543,7 +543,7 @@ There are no consensus-breaking changes. specificity in functionality. ([\#837](https://github.com/cosmos/ibc-rs/issues/837)) - `[ibc-app-transfer]` Add `memo` field to `escrow-coins-*()` and - `burn-coins-*()` methods, allowing implementors to pass in arbitrary data + `burn-coins-*()` methods, allowing implementers to pass in arbitrary data necessary for their use case. ([\#839](https://github.com/cosmos/ibc-rs/issues/837)) - `[ibc-core-host-type]` Optimize `IdentifierError` variants and make them diff --git a/docs/architecture/adr-001-handler-implementation.md b/docs/architecture/adr-001-handler-implementation.md index e3c8e76f6f..c96020a048 100644 --- a/docs/architecture/adr-001-handler-implementation.md +++ b/docs/architecture/adr-001-handler-implementation.md @@ -311,7 +311,7 @@ pub fn keep( > This section is very much a work in progress, as further investigation into what > a production-ready implementation of the `ctx` parameter of the top-level dispatcher -> is required. As such, implementors should feel free to disregard the recommendations +> is required. As such, implementers should feel free to disregard the recommendations > below, and are encouraged to come up with amendments to this ADR to better capture > the actual requirements. diff --git a/docs/architecture/adr-007-light-client-contexts.md b/docs/architecture/adr-007-light-client-contexts.md index 5bf30de70c..eef90f4ac8 100644 --- a/docs/architecture/adr-007-light-client-contexts.md +++ b/docs/architecture/adr-007-light-client-contexts.md @@ -49,7 +49,7 @@ The `ClientStateValidation` and `ClientStateExecution` traits are the most impor #### `ClientStateValidation` -Say the implementation of a light client needs a `get_resource_Y()` method from the host in `ClientState::verify_client_message()`. The implementor would first define a trait for the host to implement. +Say the implementation of a light client needs a `get_resource_Y()` method from the host in `ClientState::verify_client_message()`. The implementer would first define a trait for the host to implement. ```rust trait MyClientValidationContext {