Merge pull request #1044 from informalsystems/th/ext-csmwsm-ex

thpani · web-flow · commit cdd9afa7dd9b · 2023-07-14T09:37:05.000+02:00
Extend CosmWasm example with state machine + invariants
diff --git a/examples/cosmwasm/zero-to-hero/vote.qnt b/examples/cosmwasm/zero-to-hero/vote.qnt
@@ -1,5 +1,5 @@
 /// A Quint specification following Callum-A's cosmwasm-zero-to-hero tutorial:
-/// https://github.com/Callum-A/cosmwasm-zero-to-hero
+/// https://github.com/Callum-A/cosmwasm-zero-to-hero/tree/03e33968f588b192c04fadb984ae853b7dc5e64e
 ///
 /// We refer to the relevant tutorial chapters in comments below.
 
@@ -14,7 +14,7 @@ module vote {
   type UUID = str
   type Uint64 = int  // FIXME: account for under/overflows
 
-  val None: Addr = ""
+  pure val None: Addr = ""
 
   type Config = {
     admin: Addr,
@@ -76,12 +76,18 @@ module vote {
   type QueryPoll = { poll_id: str }
   type QueryVote = { poll_id: str, address: Addr }
 
+  // 13 - Query
+
+  type AllPollsResponse = { polls: List[Poll] }
+  type PollResponse = { poll: List[Poll] }
+  type VoteResponse = { vote: List[Ballot] }
+
   /*** Functional layer ***/
 
   // 06 - Instantiate
   // https://github.com/Callum-A/cosmwasm-zero-to-hero/tree/main/06%20-%20Instantiate
 
-  def instantiate(cs: ContractState, info: MessageInfo,
+  pure def instantiate(cs: ContractState, info: MessageInfo,
                   msg: InstantiateMsg): ContractState = {
     val admin = if (msg.admin != None) msg.admin else info.sender
     // TODO: deps.api.addr_validate(&admin)?
@@ -91,7 +97,7 @@ module vote {
   // 09 - Execute 1
   // https://github.com/Callum-A/cosmwasm-zero-to-hero/tree/main/09%20-%20Execute%201
 
-  def execute_create_poll(cs: ContractState, info: MessageInfo, poll_id: UUID,
+  pure def execute_create_poll(cs: ContractState, info: MessageInfo, poll_id: UUID,
                           question: str, options: List[str]): Result = {
     if (options.length() > 10) {
       { cs: cs, error: "TooManyOptions" }
@@ -112,7 +118,7 @@ module vote {
   // 10 - Execute 2
   // https://github.com/Callum-A/cosmwasm-zero-to-hero/tree/main/10%20-%20Execute%202
 
-  def execute_vote(cs: ContractState, info: MessageInfo, poll_id: UUID,
+  pure def execute_vote(cs: ContractState, info: MessageInfo, poll_id: UUID,
                    vote: str): Result = {
     // CosmWasm: POLLS.may_load(deps.storage, poll_id.clone())?;
     if (not(cs.polls.keys().contains(poll_id))) {
@@ -154,23 +160,27 @@ module vote {
   // 13 - Query
   // https://github.com/Callum-A/cosmwasm-zero-to-hero/tree/main/13%20-%20Query
 
-  def query_all_polls(cs: ContractState): List[Poll] = {
-    cs.polls.keys().fold([], (res, poll_id) => res.append(cs.polls.get(poll_id)))
+  pure def query_all_polls(cs: ContractState): AllPollsResponse = {
+    val polls = cs.polls.keys().fold([], (res, poll_id) =>
+                                    res.append(cs.polls.get(poll_id)))
+    { polls: polls }
   }
 
-  def query_poll(cs: ContractState, poll_id: UUID): List[Poll] = {
-    cs.polls.keys().fold([], (res, pid) => {
+  pure def query_poll(cs: ContractState, poll_id: UUID): PollResponse = {
+    val poll = cs.polls.keys().fold([], (res, pid) => {
       if (pid == poll_id) res.append(cs.polls.get(poll_id)) else res
     })
+    { poll: poll }
   }
 
-  def query_vote(cs: ContractState, address: Addr, poll_id: UUID): List[Ballot] = {
+  pure def query_vote(cs: ContractState, address: Addr, poll_id: UUID): VoteResponse = {
     val _key = (address, poll_id)
-    if (cs.ballots.keys().contains(_key)) {
+    val vote = if (cs.ballots.keys().contains(_key)) {
       [ cs.ballots.get(_key) ]
     } else {
       []
     }
+    { vote: vote }
   }
 }
 
@@ -179,11 +189,11 @@ module vote {
 module tests {
   import vote.*
 
-  // 17 - Instantiate Test
+  // 07 - Instantiate Test
   // https://github.com/Callum-A/cosmwasm-zero-to-hero/tree/main/07%20-%20Instantiate%20Test
 
-  val ADDR1: Addr = "addr1"
-  val ADDR2: Addr = "addr2"
+  pure val ADDR1: Addr = "addr1"
+  pure val ADDR2: Addr = "addr2"
 
   // To run:
   // quint test --main=tests --match=test_ vote.qnt
@@ -201,6 +211,7 @@ module tests {
   run test_execute_create_poll_valid = {
     val _cs_init = { config: { admin: "__UNINIT__" }, polls: Map(), ballots: Map() }
     val info = { sender: ADDR1 }
+    // Instantiate the contract
     val msg_inst = { admin: None }
     val _res_inst = instantiate(_cs_init, info, msg_inst)
 
@@ -219,6 +230,7 @@ module tests {
   run test_execute_create_poll_invalid = {
     val _cs_init = { config: { admin: "__UNINIT__" }, polls: Map(), ballots: Map() }
     val info = { sender: ADDR1 }
+    // Instantiate the contract
     val msg_inst = { admin: None }
     val _res_inst = instantiate(_cs_init, info, msg_inst)
 
@@ -235,6 +247,7 @@ module tests {
   run test_execute_vote_valid = {
     val _cs_init = { config: { admin: "__UNINIT__" }, polls: Map(), ballots: Map() }
     val info = { sender: ADDR1 }
+    // Instantiate the contract
     val msg_inst = { admin: None }
     val _res_inst = instantiate(_cs_init, info, msg_inst)
 
@@ -264,6 +277,7 @@ module tests {
   run test_execute_vote_invalid = {
     val _cs_init = { config: { admin: "__UNINIT__" }, polls: Map(), ballots: Map() }
     val info = { sender: ADDR1 }
+    // Instantiate the contract
     val msg_inst = { admin: None }
     val _res_inst = instantiate(_cs_init, info, msg_inst)
 
@@ -282,4 +296,221 @@ module tests {
     val _res = execute_vote(_res_create.cs, info, msg.poll_id, msg.vote)
     assert(_res.error != "")
   }
+
+  // 14 - Query Tests
+  // https://github.com/Callum-A/cosmwasm-zero-to-hero/tree/main/14%20-%20Query%20Tests
+
+  run test_query_all_polls = {
+    val _cs_init = { config: { admin: "__UNINIT__" }, polls: Map(), ballots: Map() }
+    val info = { sender: ADDR1 }
+    // Instantiate the contract
+    val msg_inst = { admin: None }
+    val _res_inst = instantiate(_cs_init, info, msg_inst)
+
+    // Create a poll
+    val msg_create = {
+        poll_id: "some_id_1",
+        question: "What's your favourite Cosmos coin?",
+        options: [ "Cosmos Hub", "Juno", "Osmosis" ]
+    }
+    val _res_create = execute_create_poll(_res_inst, info, msg_create.poll_id,
+                                          msg_create.question, msg_create.options)
+
+    // Create a second poll
+    val msg_create2 = {
+      poll_id: "some_id_2",
+      question: "What's your colour?",
+      options: [ "Red", "Green", "Blue" ]
+    }
+    val _res_create2 = execute_create_poll(_res_create.cs, info, msg_create2.poll_id,
+                                           msg_create2.question, msg_create2.options)
+
+    // Query
+    val res = query_all_polls(_res_create2.cs)
+    assert(res.polls.length() == 2)
+  }
+
+  run test_query_poll = {
+    val _cs_init = { config: { admin: "__UNINIT__" }, polls: Map(), ballots: Map() }
+    val info = { sender: ADDR1 }
+    // Instantiate the contract
+    val msg_inst = { admin: None }
+    val _res_inst = instantiate(_cs_init, info, msg_inst)
+
+    // Create a poll
+    val msg_create = {
+        poll_id: "some_id_1",
+        question: "What's your favourite Cosmos coin?",
+        options: [ "Cosmos Hub", "Juno", "Osmosis" ]
+    }
+    val _res_create = execute_create_poll(_res_inst, info, msg_create.poll_id,
+                                          msg_create.question, msg_create.options)
+
+    // Query for the poll that exists
+    val msg1 = { poll_id: "some_id_1" }
+    val res1 = query_poll(_res_create.cs, msg1.poll_id)
+
+    // Query for the poll that does not exists
+    val msg2 = { poll_id: "some_id_not_exist" }
+    val res2 = query_poll(_res_create.cs, msg2.poll_id)
+
+    all {
+      // Expect a poll
+      assert(res1.poll.length() == 1),
+      // Expect none
+      assert(res2.poll.length() == 0)
+    }
+  }
+
+  run test_query_vote = {
+    val _cs_init = { config: { admin: "__UNINIT__" }, polls: Map(), ballots: Map() }
+    val info = { sender: ADDR1 }
+    val msg_inst = { admin: None }
+    val _res_inst = instantiate(_cs_init, info, msg_inst)
+
+    // Create a poll
+    val msg_create = {
+        poll_id: "some_id_1",
+        question: "What's your favourite Cosmos coin?",
+        options: [ "Cosmos Hub", "Juno", "Osmosis" ]
+    }
+    val _res_create = execute_create_poll(_res_inst, info, msg_create.poll_id,
+                                          msg_create.question, msg_create.options)
+
+    // Create a vote, first time voting
+    val msg_vote = { poll_id: "some_id_1", vote: "Juno" }
+    val _res_vote = execute_vote(_res_create.cs, info, msg_vote.poll_id, msg_vote.vote)
+
+    // Query for a vote that exists
+    val msg1 = { poll_id: "some_id_1", address: ADDR1 }
+    val res1 = query_vote(_res_vote.cs, msg1.address, msg1.poll_id)
+
+    // Query for a vote that does not exists
+    val msg2 = { poll_id: "some_id_2", address: ADDR2 }
+    val res2 = query_vote(_res_vote.cs, msg2.address, msg2.poll_id)
+
+    all {
+      // Expect the vote to exist
+      assert(res1.vote.length() == 1),
+      // Expect the vote to not exist
+      assert(res2.vote.length() == 0)
+    }
+  }
+}
+
+/*** State machine ***/
+
+module state {
+  import vote.*
+
+  var state: ContractState
+
+  pure val ADMIN: Addr = "admin"
+  pure val USER_ADDR = Set("alice", "bob", "charlie", "eve")
+  pure val ALL_ADDR = USER_ADDR.union(Set(ADMIN))
+  pure val OPTIONS = Set("o1", "o2", "o3")
+
+  action init = {
+    val pre_init_state = { config: { admin: None }, polls: Map(), ballots: Map() }
+    val info = { sender: ADMIN }
+    val msg_inst = { admin: ADMIN }
+    state' = instantiate(pre_init_state, info, msg_inst)
+  }
+
+  action exec_create_poll(sender: Addr, poll_id: str, question: str, options: List[str]): bool = {
+    val info = { sender: sender }
+    val res = execute_create_poll(state, info, poll_id, question, options)
+    all {
+      res.error == "",
+      state' = res.cs
+    }
+  }
+
+  action exec_vote(sender: Addr, poll_id: UUID, vote: str): bool = {
+    val info = { sender: sender }
+    val res = execute_vote(state, info, poll_id, vote)
+    all {
+      res.error == "",
+      state' = res.cs
+    }
+  }
+
+  action step = {
+    nondet sender = ALL_ADDR.oneOf()
+    nondet poll_id = Set("p1", "p2", "p3", "p4").oneOf()
+    any {
+      nondet question = Set("q1", "q2", "q3", "q4").oneOf()
+      nondet options = OPTIONS.powerset().oneOf()
+      val optionsL = options.fold([], (s, o) => s.append(o))
+      exec_create_poll(sender, poll_id, question, optionsL),
+
+      nondet option = OPTIONS.oneOf()
+      exec_vote(sender, poll_id, option)
+    }
+  }
+
+  // Invariant: An admin is always set in the contract's config.
+  //
+  // To check:
+  // quint run --main=state --invariant=alwaysAdmin vote.qnt
+  val alwaysAdmin = state.config.admin != None
+
+  // Return true iff `pred(e)` is true for all elements `e` of `list`.
+  pure def listForall(list: List[a], pred: a => bool): bool = {
+    list.foldl(true, (b, elem) => { if (pred(elem)) b else false })
+  }
+
+  // FIXME(#1042): work around binding issue
+  pure def listForall2(list: List[a], pred: a => bool): bool = {
+    list.foldl(true, (b, elem) => { if (pred(elem)) b else false })
+  }
+
+  // Invariant: The ballots in `ballots` sum up to the aggregated votes in
+  //            `polls[id].options`.
+  //
+  // To check:
+  // quint run --main=state --invariant=invBallotsMatchPolls vote.qnt
+  //
+  // Note: This invariant DOES NOT hold in the current implementation / spec.
+  //       Can you guess why?
+  //       [`execute_vote` allows to replace a poll in `polls` without nuking
+  //        already submitted ballots in `ballots`.]
+  val invBallotsMatchPolls = {
+    state.polls.keys().forall(poll_id =>
+      // sum the votes in `ballots` into a map `question -> num_votes`:
+      val affected_ballot_keys = state.ballots.keys().filter(k => k._2 == poll_id)
+      val summed_ballots = affected_ballot_keys.fold(Map(), (m, k) =>
+        val option = state.ballots.get(k).option
+        if(m.keys().contains(option)) {
+          m.setBy(option, old => old + 1)
+        } else {
+          m.put(option, 1)
+        }
+      )
+      // assert that aggregated sum in `polls[poll_id]` equals the sum from above
+      val poll = state.polls.get(poll_id)
+      poll.options.listForall(option =>
+        val optionKey = option._1
+        val optionSum = option._2
+        // `ballots` only contains entries if there are > 0 votes.
+        optionSum > 0 implies and {
+          summed_ballots.keys().contains(optionKey),
+          summed_ballots.get(optionKey) == optionSum
+        }
+      )
+    )
+  }
+
+  // Invariant: The aggregated votes for all options of all polls are greater 0.
+  //
+  // To check:
+  // quint run --main=state --invariant=invAllBallotsPositive vote.qnt
+  //
+  // Note: This invariant DOES NOT hold in the current implementation / spec.
+  //       Can you guess why?
+  //       [`execute_vote` allows to replace a poll in `polls` without nuking
+  //        already submitted ballots in `ballots`, but `execute_vote` adjusts
+  //        the sum differently based on whether such a ballot is present.]
+  val invAllBallotsPositive = query_all_polls(state).polls.listForall(poll =>
+                                poll.options.listForall(opt => opt._2 >= 0))
 }
