Skip to content
This repository was archived by the owner on Jun 24, 2024. It is now read-only.

Investigate and refactor mock rollup for committing states #40

Closed
Tracked by #26
Farhad-Shabani opened this issue Dec 7, 2023 · 0 comments · Fixed by #42
Closed
Tracked by #26

Investigate and refactor mock rollup for committing states #40

Farhad-Shabani opened this issue Dec 7, 2023 · 0 comments · Fixed by #42
Assignees
Labels
explore Further investigation needed modules Related to ibc modules testing Cause to test more aspects of product

Comments

@Farhad-Shabani
Copy link
Member

Description

While writing token transfer tests #36, we encountered a roadblock due to the lack of access to proof of commitments on our mock rollup. Therefore, we were unable to craft any IBC messages that require a commitment proof, resulting in the incomplete execution of the token transfer test from the mock rollup to the mock cosmos chain. In this case, MsgRecvPacket couldn't be constructed.

Proposal

This necessitates a deeper investigation into how committing states work in the Sovereign SDK. Subsequently, we should consider refactoring our mock rollup abstraction to allow the persistence of pending changes in a WorkingSet and the ability to roll forward the execution.

@Farhad-Shabani Farhad-Shabani added explore Further investigation needed testing Cause to test more aspects of product labels Dec 7, 2023
@github-project-automation github-project-automation bot moved this to 📥 To Do in sovereign-ibc Dec 7, 2023
@Farhad-Shabani Farhad-Shabani added the modules Related to ibc modules label Dec 7, 2023
@Farhad-Shabani Farhad-Shabani changed the title Investigate and refactor Mock rollup abstraction for committing states Investigate and refactor mock rollup for committing states Dec 7, 2023
@Farhad-Shabani Farhad-Shabani self-assigned this Dec 7, 2023
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in sovereign-ibc Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
explore Further investigation needed modules Related to ibc modules testing Cause to test more aspects of product
Projects
Status: ✅ Done
1 participant