Android destroy could craches the app

[JumBay]

Hi,

In https://github.com/ingageco/capacitor-music-controls-plugin/blob/master/android/src/main/java/com/ingageco/capacitormusiccontrols/CapacitorMusicControls.java#L188, could you replace:

notification.destroy();

By

if (notification != null) {
   notification.destroy();
}

To avoid have the app crashes if notification is not defined.

Thanks for the great work.

[eamador]

Hi @JumBay, that was done here https://github.com/ingageco/capacitor-music-controls-plugin/pull/8/files, it is merged already!

[ingageco]

@eamador is right - when i saw this last week, i thought the same thing. let me know if we are wrong, or if a something doesn't reflect the change (like npm).

[JumBay]

When I was testing the plugin, calling CapacitorMusicControls.destroy() when controls weren't created yet would crash the app because notification was not defined. I can do another try but I guess it will do the same since there was no change in code so far.

[JumBay]

I did test again and it still crashes on android, works on ios :

E/Capacitor: Serious error executing plugin
    java.lang.reflect.InvocationTargetException
        at java.lang.reflect.Method.invoke(Native Method)
        at com.getcapacitor.PluginHandle.invoke(PluginHandle.java:99)
        at com.getcapacitor.Bridge$1.run(Bridge.java:521)
        at android.os.Handler.handleCallback(Handler.java:883)
        at android.os.Handler.dispatchMessage(Handler.java:100)
        at android.os.Looper.loop(Looper.java:214)
        at android.os.HandlerThread.run(HandlerThread.java:67)
     Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'void com.ingageco.capacitormusiccontrols.MusicControlsNotification.destroy()' on a null object reference
        at com.ingageco.capacitormusiccontrols.CapacitorMusicControls.destroy(CapacitorMusicControls.java:191)
        at java.lang.reflect.Method.invoke(Native Method) 

[mlnisd]

@JumBay I'm currently running into this issue myself. Are you still experiencing this or was there a fix/workaround?

[mlnisd]

UPDATE: Fixed using fix at line 188. Also had to set a value of "" for:

• artist
• playIcon
• pauseIcon
• prevIcon
• nextIcon
• closeIcon
• notificationIcon

even though these are optional?

[JumBay]

@mlnisd I didn't try so far but I guess the issue is still there. I use my fork https://github.com/wako-app/capacitor-music-controls-plugin btw

[mlnisd]

@ingageco Would it possible to merge the fix from @JumBay #12, fixes the error they mentioned above on Android