chore(repo): clippy / fmt

With the new edition/version bump there's a bunch of clippy / fmt changes to do.

Author: Evalir

crates/blobber/src/block_data.rs

@@ -1,11 +1,11 @@
 use crate::{
-    error::UnrecoverableBlobError, shim::ExtractableChainShim, BlockExtractionError,
-    BlockExtractorBuilder, ExtractionResult,
+    BlockExtractionError, BlockExtractorBuilder, ExtractionResult, error::UnrecoverableBlobError,
+    shim::ExtractableChainShim,
 };
 use alloy::{
     consensus::{Blob, SidecarCoder, SimpleCoder},
     eips::eip7594::BlobTransactionSidecarVariant,
-    primitives::{keccak256, TxHash, B256},
+    primitives::{B256, TxHash, keccak256},
 };
 use init4_bin_base::utils::calc::SlotCalculator;
 use reth::{
@@ -334,15 +334,15 @@ mod tests {
             BlobTransactionSidecar, SidecarBuilder, SignableTransaction, TxEip2930, TxEnvelope,
         },
         eips::Encodable2718,
-        primitives::{bytes, Address, TxKind, U256},
+        primitives::{Address, TxKind, U256, bytes},
         rlp::encode,
-        signers::{local::PrivateKeySigner, SignerSync},
+        signers::{SignerSync, local::PrivateKeySigner},
     };
     use foundry_blob_explorers::TransactionDetails;
     use reth::primitives::{Transaction, TransactionSigned};
     use reth_transaction_pool::{
-        test_utils::{testing_pool, MockTransaction},
         PoolTransaction, TransactionOrigin,
+        test_utils::{MockTransaction, testing_pool},
     };
     use signet_types::constants::SignetSystemConstants;
 

crates/db/src/provider.rs

@@ -1,11 +1,11 @@
 use crate::{
+    DataCompat, DbZenithHeader, RuChain, ZenithHeaders,
     tables::{DbSignetEvent, JournalHashes, SignetEvents},
     traits::RuWriter,
-    DataCompat, DbZenithHeader, RuChain, ZenithHeaders,
 };
 use alloy::{
     consensus::{BlockHeader, TxReceipt},
-    primitives::{map::HashSet, Address, BlockNumber, B256, U256},
+    primitives::{Address, B256, BlockNumber, U256, map::HashSet},
 };
 use reth::{
     primitives::{Account, StaticFileSegment},
@@ -17,13 +17,13 @@ use reth::{
     },
 };
 use reth_db::{
+    PlainAccountState,
     cursor::{DbCursorRO, DbCursorRW},
     models::{BlockNumberAddress, StoredBlockBodyIndices},
     tables,
     transaction::{DbTx, DbTxMut},
-    PlainAccountState,
 };
-use reth_prune_types::{PruneMode, MINIMUM_PRUNING_DISTANCE};
+use reth_prune_types::{MINIMUM_PRUNING_DISTANCE, PruneMode};
 use signet_evm::BlockResult;
 use signet_node_types::{NodeTypesDbTrait, SignetNodeTypes};
 use signet_types::primitives::RecoveredBlock;

crates/db/src/tables.rs

@@ -1,10 +1,11 @@
 use alloy::{
-    primitives::{bytes::BufMut, Address, BlockNumber, Bytes, B256, U256},
+    primitives::{Address, B256, BlockNumber, Bytes, U256, bytes::BufMut},
     rlp::Buf,
 };
 use reth_db::{
+    DatabaseError,
     table::{Compress, Decompress, DupSort, Table},
-    tables, DatabaseError,
+    tables,
 };
 use signet_zenith::{
     Passage::{Enter, EnterToken},

crates/db/src/traits.rs

@@ -1,5 +1,5 @@
 use crate::{DbExtractionResults, DbSignetEvent, RuChain};
-use alloy::primitives::{Address, BlockNumber, B256, U256};
+use alloy::primitives::{Address, B256, BlockNumber, U256};
 use itertools::Itertools;
 use reth::{
     primitives::Account,

crates/rpc/examples/filler.rs

@@ -3,16 +3,16 @@ use alloy::{
     network::{Ethereum, EthereumWallet, TransactionBuilder},
     primitives::Bytes,
     providers::{
+        Identity, Provider as _, RootProvider, SendableTx,
         fillers::{
             BlobGasFiller, ChainIdFiller, FillProvider, GasFiller, JoinFill, NonceFiller,
             WalletFiller,
         },
-        Identity, Provider as _, RootProvider, SendableTx,
     },
-    rpc::types::{mev::EthSendBundle, TransactionRequest},
+    rpc::types::{TransactionRequest, mev::EthSendBundle},
     signers::Signer,
 };
-use eyre::{eyre, Error};
+use eyre::{Error, eyre};
 use signet_bundle::SignetEthBundle;
 use signet_constants::SignetConstants;
 use signet_tx_cache::{client::TxCache, types::TxCacheSendBundleResponse};

crates/rpc/examples/order.rs

@@ -1,11 +1,11 @@
 use alloy::{
     consensus::constants::GWEI_TO_WEI,
-    primitives::{uint, U256},
+    primitives::{U256, uint},
     signers::Signer,
 };
 use chrono::Utc;
 use eyre::Error;
-use signet_constants::{SignetConstants, NATIVE_TOKEN_ADDRESS};
+use signet_constants::{NATIVE_TOKEN_ADDRESS, SignetConstants};
 use signet_tx_cache::client::TxCache;
 use signet_types::UnsignedOrder;
 use signet_zenith::RollupOrders::{Input, Order, Output};

crates/rpc/src/config.rs

@@ -1,4 +1,4 @@
-use ajj::{pubsub::ServerShutdown, Router};
+use ajj::{Router, pubsub::ServerShutdown};
 use reth::{args::RpcServerArgs, tasks::TaskExecutor};
 use std::net::SocketAddr;
 use tokio::task::JoinHandle;

crates/rpc/src/ctx.rs

@@ -1,9 +1,9 @@
 use crate::{
+    Pnt,
     eth::EthError,
     interest::{ActiveFilter, FilterManager, FilterOutput, SubscriptionManager},
     receipts::build_signet_receipt,
     util::BlockRangeInclusiveIter,
-    Pnt,
 };
 use alloy::{
     consensus::{BlockHeader, Header, Signed, Transaction, TxEnvelope},
@@ -16,21 +16,21 @@ use reth::{
     core::primitives::SignerRecoverable,
     primitives::{Block, EthPrimitives, Receipt, Recovered, RecoveredBlock, TransactionSigned},
     providers::{
-        providers::{BlockchainProvider, ProviderNodeTypes},
         BlockHashReader, BlockIdReader, BlockNumReader, CanonStateSubscriptions, HeaderProvider,
         ProviderBlock, ProviderError, ProviderReceipt, ReceiptProvider, StateProviderFactory,
         TransactionsProvider,
+        providers::{BlockchainProvider, ProviderNodeTypes},
     },
     revm::{database::StateProviderDatabase, primitives::hardfork::SpecId},
     rpc::{
         eth::{filter::EthFilterError, helpers::types::EthRpcConverter},
         server_types::eth::{
+            EthApiError, EthConfig, EthStateCache, FeeHistoryCache, FeeHistoryEntry,
+            GasPriceOracle,
             fee_history::{
                 calculate_reward_percentiles_for_block, fee_history_cache_new_blocks_task,
             },
-            logs_utils::{self, append_matching_block_logs, ProviderOrBlock},
-            EthApiError, EthConfig, EthStateCache, FeeHistoryCache, FeeHistoryEntry,
-            GasPriceOracle,
+            logs_utils::{self, ProviderOrBlock, append_matching_block_logs},
         },
         types::{FilterBlockOption, FilteredParams},
     },
@@ -41,12 +41,12 @@ use reth_node_api::{BlockBody, FullNodeComponents};
 use reth_rpc_eth_api::{RpcBlock, RpcConvert, RpcReceipt, RpcTransaction};
 use signet_evm::EvmNeedsTx;
 use signet_tx_cache::client::TxCache;
-use signet_types::{constants::SignetSystemConstants, MagicSig};
+use signet_types::{MagicSig, constants::SignetSystemConstants};
 use std::{marker::PhantomData, sync::Arc};
-use tracing::{instrument, trace, Level};
+use tracing::{Level, instrument, trace};
 use trevm::{
-    revm::{context::CfgEnv, database::StateBuilder},
     Cfg,
+    revm::{context::CfgEnv, database::StateBuilder},
 };
 
 /// Type alias for EVMs using a [`StateProviderBox`] as the `DB` type for
@@ -326,7 +326,6 @@ where
         Ok(Some((hash, header)))
     }
 
-
     /// Get the block for a given block, returning the block hash and
     /// the block itself.
     pub async fn raw_block(

crates/rpc/src/eth/mod.rs

@@ -7,7 +7,7 @@ pub use error::EthError;
 mod helpers;
 pub use helpers::CallErrorData;
 
-use crate::{ctx::RpcCtx, Pnt};
+use crate::{Pnt, ctx::RpcCtx};
 use alloy::{eips::BlockNumberOrTag, primitives::B256};
 use reth_node_api::FullNodeComponents;
 

crates/rpc/src/interest/filters.rs

@@ -3,12 +3,12 @@ use alloy::{
     primitives::{B256, U64},
     rpc::types::{Filter, Log},
 };
-use dashmap::{mapref::one::RefMut, DashMap};
+use dashmap::{DashMap, mapref::one::RefMut};
 use std::{
     collections::VecDeque,
     sync::{
-        atomic::{AtomicU64, Ordering},
         Arc, Weak,
+        atomic::{AtomicU64, Ordering},
     },
     time::{Duration, Instant},
 };
@@ -71,9 +71,9 @@ impl FilterOutput {
     pub fn extend(&mut self, other: Self) {
         match (self, other) {
             // If we're a log, we can extend with other logs
-            (Self::Log(ref mut logs), Self::Log(other_logs)) => logs.extend(other_logs),
+            (Self::Log(logs), Self::Log(other_logs)) => logs.extend(other_logs),
             // If we're a block, we can extend with other blocks
-            (Self::Block(ref mut blocks), Self::Block(other_blocks)) => blocks.extend(other_blocks),
+            (Self::Block(blocks), Self::Block(other_blocks)) => blocks.extend(other_blocks),
             // Extending with empty is a noop
             (_, Self::Empty(_)) => (),
             // If we're empty, just take the other value
@@ -108,22 +108,14 @@ impl From<Vec<Log>> for FilterOutput {
 impl FromIterator<Log> for FilterOutput {
     fn from_iter<T: IntoIterator<Item = Log>>(iter: T) -> Self {
         let inner: VecDeque<_> = iter.into_iter().collect();
-        if inner.is_empty() {
-            Self::empty()
-        } else {
-            Self::Log(inner)
-        }
+        if inner.is_empty() { Self::empty() } else { Self::Log(inner) }
     }
 }
 
 impl FromIterator<B256> for FilterOutput {
     fn from_iter<T: IntoIterator<Item = B256>>(iter: T) -> Self {
         let inner: VecDeque<_> = iter.into_iter().collect();
-        if inner.is_empty() {
-            Self::empty()
-        } else {
-            Self::Block(inner)
-        }
+        if inner.is_empty() { Self::empty() } else { Self::Block(inner) }
     }
 }
 
@@ -294,12 +286,14 @@ impl FilterCleanTask {
     /// [`DashMap::retain`]'s deadlock condition is not met. See [`DashMap`]
     /// documentation for more information.
     fn spawn(self) {
-        std::thread::spawn(move || loop {
-            std::thread::sleep(self.sleep);
-            trace!("cleaning stale filters");
-            match self.manager.upgrade() {
-                Some(manager) => manager.clean_stale(self.age_limit),
-                None => break,
+        std::thread::spawn(move || {
+            loop {
+                std::thread::sleep(self.sleep);
+                trace!("cleaning stale filters");
+                match self.manager.upgrade() {
+                    Some(manager) => manager.clean_stale(self.age_limit),
+                    None => break,
+                }
             }
         });
     }