Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Implement new core caching api functions. #28

Closed
1 task done
spacedmonkey opened this issue Apr 17, 2023 · 3 comments
Closed
1 task done

[Feature Request]: Implement new core caching api functions. #28

spacedmonkey opened this issue Apr 17, 2023 · 3 comments

Comments

@spacedmonkey
Copy link

Is your feature request related to a problem?

There has been a number of improve to the caching api, including. Adding the following functions.

  • wp_cache_flush_runtime
  • wp_cache_add_multiple
  • wp_cache_set_multiple
  • wp_cache_delete_multiple
  • wp_cache_flush_group
  • wp_cache_supports

Describe the desired solution

Implement core functions.

Describe the alternatives that you have considered

N / A

Additional context

https://make.wordpress.org/core/2022/04/29/caching-improvements-in-wordpress-6-0/
https://make.wordpress.org/core/2022/10/11/performance-field-guide-for-wordpress-6-1/

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Biont
Copy link
Member

Biont commented Apr 25, 2023

Hello @spacedmonkey and thank you for raising this.
This is definitely something worth picking up and we'll try to allocate some time soon.

It should be noted that the *_multiple are unlikely to yield any improvements, because the underlying StashPHP library itself only unwraps these calls back into single-item operations
(See also #18 for reference)

There is still value in implementing them for future-proofing, though

@spacedmonkey
Copy link
Author

Thanks @Biont

The biggest one of this list I would like to see implemented is wp_cache_supports. I am core committer and it is extremely useful to understand what feature your object cache supports. Specially group flush and multiple gets. We can't use these features in core unless we know they are supported.

See WordPress/performance#718 for more context.

@Biont Biont mentioned this issue Apr 28, 2023
3 tasks
@Biont
Copy link
Member

Biont commented Jun 16, 2023

@Biont Biont closed this as completed Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants