Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git submodule sync is not in right sequence #185

Open
amagyar-iohk opened this issue Mar 14, 2024 · 1 comment
Open

Git submodule sync is not in right sequence #185

amagyar-iohk opened this issue Mar 14, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@amagyar-iohk
Copy link
Contributor

Is this a regression?

No

Description

After changing the build scripts and the submodule paths the build script is not syncing up the submodules before updating the submodules, which will lead to unexpected behavior.
The script will work on new clone but anyone who has cloned the repo before will not be able to build

We should run the git submodule sync before

Please provide the exception or error you saw

npm run build

> @atala/[email protected] build
> npm run externals:update && rm -rf build && npm run build:browser && npm run build:node && npm run types


> @atala/[email protected] externals:update
> ./externals/run.sh -x update

Updating submodules
fatal: Unable to find refs/remotes/origin/feature/wasm revision in submodule path 'externals/anoncreds'
Build AnonCreds
Error: crate directory is missing a `Cargo.toml` file; is `.` the wrong directory?
Caused by: crate directory is missing a `Cargo.toml` file; is `.` the wrong directory?
mv: rename pkg to /Users/io/iog/repos/atala-prism-wallet-sdk-ts/externals/generated/anoncreds-wasm-browser: No such file or directory
Error: crate directory is missing a `Cargo.toml` file; is `.` the wrong directory?
Caused by: crate directory is missing a `Cargo.toml` file; is `.` the wrong directory?
mv: rename pkg to /Users/io/iog/repos/atala-prism-wallet-sdk-ts/externals/generated/anoncreds-wasm-node: No such file or directory
./externals/run.sh: line 66: cd: /Users/io/iog/repos/atala-prism-wallet-sdk-ts/externals/generated/anoncreds-wasm-browser: No such file or directory
sed: 1: "./anoncreds.js": invalid command code .
Build DIDComm
./externals/run.sh: line 34: cd: /Users/io/iog/repos/atala-prism-wallet-sdk-ts/externals/didcomm/wasm: No such file or directory
Error: crate directory is missing a `Cargo.toml` file; is `.` the wrong directory?
Caused by: crate directory is missing a `Cargo.toml` file; is `.` the wrong directory?
Error: crate directory is missing a `Cargo.toml` file; is `.` the wrong directory?
Caused by: crate directory is missing a `Cargo.toml` file; is `.` the wrong directory?
./externals/run.sh: line 41: cd: /Users/io/iog/repos/atala-prism-wallet-sdk-ts/externals/generated/didcomm-wasm-browser: No such file or directory
sed: 1: "didcomm_js.js": extra characters at the end of d command

> @atala/[email protected] build:browser
> rollup -c rollup/rollup.browser.mjs


### Please provide the environment you discovered this bug in

_No response_

### Anything else?

_No response_
@mkbreuningIOHK mkbreuningIOHK added the enhancement New feature or request label Mar 18, 2024
@mkbreuningIOHK
Copy link
Contributor

@curtis-h , have you been able to look into this issue yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants