fixup! feat(wallet): the wallet now only fetches UTXOs on tx history change

Author: mirceahasegan

packages/wallet/src/services/TransactionsTracker.ts

@@ -38,9 +38,7 @@ import { distinctBlock, signedTxsEquals, transactionsEquals, txInEquals } from '
 import { WitnessedTx } from '@cardano-sdk/key-management';
 import { newAndStoredMulticast } from './util/newAndStoredMulticast';
 import chunk from 'lodash/chunk.js';
-import intersectionBy from 'lodash/intersectionBy.js';
 import sortBy from 'lodash/sortBy.js';
-import unionBy from 'lodash/unionBy.js';
 
 export interface TransactionsTrackerProps {
   chainHistoryProvider: ChainHistoryProvider;
@@ -127,6 +125,7 @@ export const createAddressTransactionsProvider = ({
         )
       ),
       combineLatest([addresses$, storedTransactions$.pipe(defaultIfEmpty([] as Cardano.HydratedTx[]))]).pipe(
+        // eslint-disable-next-line sonarjs/cognitive-complexity
         switchMap(([addresses, storedTransactions]) => {
           let localTransactions: Cardano.HydratedTx[] = [...storedTransactions];
 
@@ -158,28 +157,21 @@ export const createAddressTransactionsProvider = ({
                   `chainHistoryProvider returned ${newTransactions.length} transactions`,
                   lowerBound !== undefined && `since block ${lowerBound}`
                 );
-                const duplicateTransactions =
-                  lastStoredTransaction && intersectionBy(localTransactions, newTransactions, (tx) => tx.id);
-
-                if (typeof duplicateTransactions !== 'undefined' && duplicateTransactions.length === 0) {
-                  const rollbackTransactions = localTransactions.filter(
-                    ({ blockHeader: { blockNo } }) => blockNo >= lowerBound
-                  );
-
-                  from(rollbackTransactions)
-                    .pipe(tap((tx) => logger.debug(`Transaction ${tx.id} was rolled back`)))
-                    .subscribe((v) => rollback$.next(v));
+                const txRolledBack = lastStoredTransaction && newTransactions[0]?.id !== lastStoredTransaction.id;
+                if (txRolledBack) {
+                  logger.debug(`Transaction ${lastStoredTransaction.id} was rolled back`);
+                  rollback$.next(lastStoredTransaction);
 
                   // Rollback by 1 block, try again in next loop iteration
-                  localTransactions = localTransactions.filter(({ blockHeader: { blockNo } }) => blockNo < lowerBound);
+                  localTransactions.pop();
                 } else {
-                  const lastLocalTxs = localTransactions.slice(-newTransactions.length);
-                  const areTransactionsSame =
-                    lastLocalTxs.length === newTransactions.length &&
-                    lastLocalTxs.every((tx, index) => tx.id === newTransactions[index].id);
+                  if (lastStoredTransaction) {
+                    // lastStoredTransaction is also the first in newTransactions
+                    newTransactions.shift();
+                  }
 
-                  if (!areTransactionsSame) {
-                    localTransactions = unionBy(localTransactions, newTransactions, (tx) => tx.id);
+                  localTransactions = [...localTransactions, ...newTransactions];
+                  if (newTransactions.length > 0) {
                     store.setAll(localTransactions);
                   }