refactor(cardano-services): optimize redeemer query hoisting the sort at node.js level

Author: iccicci

packages/cardano-services/src/ChainHistory/DbSyncChainHistory/ChainHistoryBuilder.ts

@@ -317,7 +317,9 @@ export class ChainHistoryBuilder {
       values: [ids]
     });
     const redeemerMap: TransactionDataMap<Cardano.Redeemer[]> = new Map();
-    for (const redeemer of result.rows) {
+    for (const redeemer of result.rows
+      .map(({ id, ...rest }) => ({ id: BigInt(id), ...rest }))
+      .sort((a, b) => Number(a.id - b.id))) {
       const txId = redeemer.tx_id.toString('hex') as unknown as Cardano.TransactionId;
       const currentRedeemers = redeemerMap.get(txId) ?? [];
       redeemerMap.set(txId, [...currentRedeemers, mapRedeemer(redeemer)]);

packages/cardano-services/src/ChainHistory/DbSyncChainHistory/mappers.ts

@@ -153,7 +153,7 @@ const mapRedeemerPurpose = (purpose: RedeemerModel['purpose']): Cardano.Redeemer
     throw new NotImplementedError(`Failed to map redeemer "purpose": ${purpose}`);
   })();
 
-export const mapRedeemer = (redeemerModel: RedeemerModel): Cardano.Redeemer => ({
+export const mapRedeemer = (redeemerModel: Omit<RedeemerModel, 'id'>): Cardano.Redeemer => ({
   data: stubRedeemerData,
   executionUnits: {
     memory: Number(redeemerModel.unit_mem),

packages/cardano-services/src/ChainHistory/DbSyncChainHistory/queries.ts

@@ -176,6 +176,7 @@ export const findWithdrawalsByTxIds = `
 
 export const findRedeemersByTxIds = `
 	SELECT
+		redeemer.id AS id,
 		redeemer."index" AS "index",
 		redeemer.purpose AS purpose,
 		redeemer.script_hash AS script_hash,
@@ -184,8 +185,7 @@ export const findRedeemersByTxIds = `
 		tx.hash AS tx_id
 	FROM redeemer
 	JOIN tx ON tx.id = redeemer.tx_id
-	WHERE tx.id = ANY($1)
-	ORDER BY redeemer.id ASC`;
+	WHERE tx.id = ANY($1)`;
 
 export const findVotingProceduresByTxIds = `
 	SELECT

packages/cardano-services/src/ChainHistory/DbSyncChainHistory/types.ts

@@ -104,6 +104,7 @@ export interface WithdrawalModel {
 }
 
 export interface RedeemerModel {
+  id: string;
   index: number;
   purpose: 'cert' | 'mint' | 'spend' | 'reward' | 'voting' | 'proposing';
   script_hash: Buffer;

packages/cardano-services/test/ChainHistory/DbSyncChainHistoryProvider/mappers.test.ts

@@ -440,7 +440,7 @@ describe('chain history mappers', () => {
     );
   });
   describe('mapRedeemer', () => {
-    const redeemerModel: Omit<RedeemerModel, 'purpose'> = {
+    const redeemerModel: Omit<RedeemerModel, 'id' | 'purpose'> = {
       index: 1,
       script_hash: Buffer.from(hash28ByteBase16, 'hex'),
       tx_id: Buffer.from(transactionHash, 'hex'),