Merge pull request #2699 from input-output-hk/jpraynaud/fix-rust-1.90.0

fix: Rust `1.90` clippy warnings

Author: jpraynaud

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "mithril-cardano-node-internal-database"
-version = "0.1.6"
+version = "0.1.7"
 description = "Mechanisms that allow Mithril nodes to read the files of a Cardano node internal database and compute digests from them"
 authors.workspace = true
 documentation.workspace = true

internal/cardano-node/mithril-cardano-node-internal-database/Cargo.toml

@@ -177,7 +177,7 @@ pub(super) struct Progress {
 impl Progress {
     pub(super) fn report(&mut self, ix: usize) -> bool {
         self.index = ix;
-        (20 * ix) % self.total == 0
+        (20 * ix).is_multiple_of(self.total)
     }
 
     pub(super) fn percent(&self) -> f64 {

internal/cardano-node/mithril-cardano-node-internal-database/src/digesters/immutable_digester.rs

@@ -211,7 +211,7 @@ impl DummyCardanoDbBuilder {
     /// Note: by default, the size of the produced files is less than 1 kb.
     pub fn set_immutable_trio_file_size(&mut self, trio_file_size: u64) -> &mut Self {
         assert!(
-            trio_file_size % 3 == 0,
+            trio_file_size.is_multiple_of(3),
             "'trio_file_size' must be a multiple of 3"
         );
 

internal/cardano-node/mithril-cardano-node-internal-database/src/test/dummy_cardano_db.rs

@@ -1,6 +1,6 @@
 [package]
 name = "mithril-aggregator"
-version = "0.7.84"
+version = "0.7.85"
 description = "A Mithril Aggregator server"
 authors = { workspace = true }
 edition = { workspace = true }

mithril-aggregator/Cargo.toml

@@ -61,8 +61,8 @@ impl From<SignerRegistrationRecord> for Signer {
             verification_key: other.verification_key.try_into().unwrap(),
             verification_key_signature: other
                 .verification_key_signature
-                .map(|k| (k.try_into().unwrap())),
-            operational_certificate: other.operational_certificate.map(|o| (o.try_into().unwrap())),
+                .map(|k| k.try_into().unwrap()),
+            operational_certificate: other.operational_certificate.map(|o| o.try_into().unwrap()),
             kes_period: other.kes_period,
         }
     }
@@ -75,8 +75,8 @@ impl From<SignerRegistrationRecord> for SignerWithStake {
             verification_key: other.verification_key.try_into().unwrap(),
             verification_key_signature: other
                 .verification_key_signature
-                .map(|k| (k.try_into().unwrap())),
-            operational_certificate: other.operational_certificate.map(|o| (o.try_into().unwrap())),
+                .map(|k| k.try_into().unwrap()),
+            operational_certificate: other.operational_certificate.map(|o| o.try_into().unwrap()),
             kes_period: other.kes_period,
             stake: other.stake.unwrap_or_default(),
         }

mithril-aggregator/src/database/record/signer_registration.rs

@@ -1019,7 +1019,7 @@ mod tests {
 
             let stake_store = {
                 assert!(
-                    self.total_stake % self.total_spo as u64 == 0,
+                    self.total_stake.is_multiple_of(self.total_spo as u64),
                     "'total_stake' must be a multiple of 'total_spo' to create a uniform stake distribution"
                 );
                 let stake_per_spo = self.total_stake / self.total_spo as u64;

mithril-aggregator/src/services/epoch_service.rs

@@ -1,6 +1,6 @@
 [package]
 name = "mithril-common"
-version = "0.6.17"
+version = "0.6.18"
 description = "Common types, interfaces, and utilities for Mithril nodes."
 authors = { workspace = true }
 edition = { workspace = true }

mithril-common/Cargo.toml

@@ -107,7 +107,7 @@ impl From<SignerWithStake> for SignerWithStakeMessagePart {
                 .map(|k| k.try_into().unwrap()),
             operational_certificate: value
                 .operational_certificate
-                .map(|op_cert| (op_cert.try_into().unwrap())),
+                .map(|op_cert| op_cert.try_into().unwrap()),
             kes_period: value.kes_period,
             stake: value.stake,
         }
@@ -230,7 +230,7 @@ impl From<Signer> for SignerMessagePart {
                 .map(|k| k.try_into().unwrap()),
             operational_certificate: value
                 .operational_certificate
-                .map(|op_cert| (op_cert.try_into().unwrap())),
+                .map(|op_cert| op_cert.try_into().unwrap()),
             kes_period: value.kes_period,
         }
     }