Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly enable pulse-on-same-line #8

Open
thirtythreeforty opened this issue Oct 26, 2015 · 3 comments
Open

Explicitly enable pulse-on-same-line #8

thirtythreeforty opened this issue Oct 26, 2015 · 3 comments

Comments

@thirtythreeforty
Copy link

Hello! This is a very cool plugin; I like it a lot!

Reading through the code, I see you explicitly don't pulse when the next match is on the same line as the last match. I would prefer that the cursorline pulse regardless of where the next match is. Could you provide an option to do that? Or, would you be open to a pull request that implements it?

Also, there is a slight glitch with the current behavior. Currently, if I press /foo<cr> to start a search, then <C-F>n to scroll up a page and jump to the next "foo", then the found foo (the one I jumped away from) is not highlighted, because it's the same line as the previous pulse. More generally, I think that moving away from a match's line, then returning to it, should pulse the cursorline.

@inside
Copy link
Owner

inside commented Oct 28, 2015

Hello George!

A pull request that implements this option would be much appreciated :-)
And if you are willing to fix the slight glitch it would be awesome.

Keep on enjoying this plugin,

Best

On Mon, Oct 26, 2015 at 10:22 PM, George Hilliard [email protected]
wrote:

Hello! This is a very cool plugin; I like it a lot!

Reading through the code, I see you explicitly don't pulse when the next
match is on the same line as the last match. I would prefer that the
cursorline pulse regardless of where the next match is. Could you provide
an option to do that? Or, would you be open to a pull request that
implements it?

Also, there is a slight glitch with the current behavior. Currently, if I
press /foo to start a search, then n to scroll up a page and
jump to the next "foo", then the found foo (the one I jumped away from) is
not highlighted, because it's the same line as the old one. More generally,
moving away from a match's then returning to it should also pulse.


Reply to this email directly or view it on GitHub
#8.

Yann / Front developer @ Dailymotion

@jebaum
Copy link
Contributor

jebaum commented Feb 23, 2016

FYI, I'm working on a PR for this

@inside
Copy link
Owner

inside commented Feb 23, 2016

Awesome, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants