Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to see video length on thumbnail #625

Open
davuthdv opened this issue Jun 27, 2020 · 6 comments
Open

Ability to see video length on thumbnail #625

davuthdv opened this issue Jun 27, 2020 · 6 comments

Comments

@davuthdv
Copy link

Please add video length on the video thumbnail just like the official Developer app from Apple.

Right now, I can see the length if I click to go to detail screen, but I would have to do it one by one. It would be great to see the length of each video in a glance so that if i have like 15 minutes, I know which one I can watch.

@aritropaul
Copy link

I'd like to work on this!

@aritropaul
Copy link

So I started out with cloning and running bootstrap.sh, and ran into an error in building RxRealm.

The linked framework 'Realm.framework' is missing one or more architectures required by this target: arm64. (in target 
RxRealm-OSX' from project 'RxRealm')

Build Failed
        Task failed with exit code 65:
        /usr/bin/xcrun xcodebuild -project 
/Users/aritropaul/Documents/Codes/iOS/wwdc/Carthage/Checkouts/RxRealm/RxRealm.xcodeproj -scheme RxRealm-OSX -configuration Release -derivedDataPath 
/Users/aritropaul/Library/Caches/org.carthage.CarthageKit/DerivedData/12.0_12A8189n/RxRealm/3.1.0 
ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES archive -archivePath /var/folders/mw/92pbl7xx03s6pb0kzn_5zny00000gn/T/RxRealm SKIP_INSTALL=YES 
GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=NO CLANG_ENABLE_CODE_COVERAGE=NO 
STRIP_INSTALLED_PRODUCT=NO (launched in /Users/aritropaul/Documents/Codes/iOS/wwdc/Carthage/Checkouts/RxRealm)

@allenhumphreys
Copy link
Collaborator

This looks like you might be using Xcode 12 which we haven't confirmed compatibility with yet.

@aritropaul
Copy link

Yeah, also had a couple of errors with dependencies not being built with Swift 5.3. Most of them resolved on being built from source, but this doesn't go away.

@allenhumphreys
Copy link
Collaborator

That's just a fact of how Carthage prebuilt binaries work as well as Swift's approach to module stability. But it sounds like you're up and running?

@insidegui
Copy link
Owner

We already show the video duration in the cell:

image

I think maybe it's not shown in the schedule tab, but it's definitely there in the videos tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants