check if conf_level_coxph and conf_level_survfit can be replaced by conf_level

[shajoezhu]

No description provided.

[edelarua]

@shajoezhu these two arguments are used in the same module so the only alternative would be to have conf_level accept a list with both confidence levels as named elements. I think this might be more confusing for users but it's definitely still an option.

[shajoezhu]

Thanks a lot @edelarua , I am taking this off the board, we will revisit this, and see if it can have some more improvments

[Melkiades]

@shajoezhu these two arguments are used in the same module so the only alternative would be to have conf_level accept a list with both confidence levels as named elements. I think this might be more confusing for users but it's definitely still an option.

I checked and it is a choice_selected object so there is probably not another solution like conf_level = c("coxph", *). I would keep this duplication and close the issue. @shajoezhu?

[shajoezhu]

i changed the label, leave this one to me for some investigation. i will close it later if it doesnt trigger new actions. thanks! :)

[m7pr]

is core label needed here? I see you ended up on a conclusion that those are two separate parameters.