-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-release activities - Potential removal of dependencies #643
Comments
I experimented with moving it to
|
I would actually consider adding The same goes for |
Thoughts? |
|
done |
Can you please check if this solves #625. If yes - please close |
# Pull Request Part of #624 Follow-up to: - #643 ### Changes description - Removes `magrittr` from `Config/Needs/verdepcheck` - Re-order `verdpecheck` with same order on `Depends`, `Imports`, `Suggests` - Re-order `pre-commit` config with same order on `Depends`, `Imports`, `Suggests` - Add remote repo to `htmlwidgets/sparkline` (despite not being updated in years) in `verdepcheck`
Part of #624 related to vignettes. Please make a PR to
pre-release@main
Consider:
{magrittr}
by importing pipe operator from{dplyr}
✔️ donetidyselect
as its functions are reexported fromdplyr
Depends
->Imports
{ggmosaic}
❌ impossible (see below){ggplot2}
❌ impossible (see below){shinyTree}
✔️ done{teal.transform}
❌ valid:teal.transform
functions should be available totmg
users{teal}
❌ valid:teal
dependency is standard in all module packages{shiny}
❌ valid: liketeal
, module packages useshiny
extensivelyThe text was updated successfully, but these errors were encountered: