You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please use the feature branch for testing: bslib@main
Use of bslib whenever possible to simplify what we already do with css/js.
Make sure that the custom CSS/JS code is isolated to the current package.
Testing - Run all the examples with main branch and this feature branch to check if the UI changes make sense or are there any changes needed. If there are new changes, mention it and create a small PR. This will invalidate the previous tests and we have to start the tests from the beginning.
It is still okay to use shiny::fluidPage and older shiny components inside a bigger bslib::fluid_page or equivalent component and the looks will remain similar. But, it’s a good idea to migrate completely as much as possible so it is easy to maintain. Additionally, the column layout from bslib is very powerful.
Sub-tasks
teal: Bring the sidebar (data summary, filter panel, transform panel) to the left side based on the discussion.
teal, teal.modules.general, teal.goshawk: Remove the custom css “teal-tooltip” feature that is used outside teal. Replace it with bslib::tooltip.
All packages: Create namespace classes and only add style class that affect these namespaces without affecting elements created outside the scope of these elements.
teal_slice: Make sure the style changes work on a normal shiny app that does not use teal.
teal_widget: Support only bootstrap 5 components and remove code related to bs3 and bs4.
The text was updated successfully, but these errors were encountered:
Continuation of #1289
When it's ready for implementation (we will create a new issue for this)
Definition of Done:
Tasks
Previous tasks
bslib
migrationAs part of this issue, we agreed to migrate teal components to use bslib and Bootstrap 5 components and close the issue https://github.com/insightsengineering/coredev-tasks/issues/587
General guidelines during the tasks:
bslib@main
bslib
whenever possible to simplify what we already do with css/js.main
branch and thisfeature
branch to check if the UI changes make sense or are there any changes needed. If there are new changes, mention it and create a small PR. This will invalidate the previous tests and we have to start the tests from the beginning.shiny::fluidPage
and older shiny components inside a biggerbslib::fluid_page
or equivalent component and the looks will remain similar. But, it’s a good idea to migrate completely as much as possible so it is easy to maintain. Additionally, the column layout from bslib is very powerful.Sub-tasks
bslib::tooltip
.The text was updated successfully, but these errors were encountered: