Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: teal doesn't warn when teal_data is not verified #1354

Open
3 tasks done
gogonzo opened this issue Sep 26, 2024 · 2 comments
Open
3 tasks done

[Feature Request]: teal doesn't warn when teal_data is not verified #1354

gogonzo opened this issue Sep 26, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@gogonzo
Copy link
Contributor

gogonzo commented Sep 26, 2024

Feature description

App which receives unverified data acts as normal. App user should be warn that the code is not reproducible. What should we do?

  • display yellow warning in show R code?
  • append warning message in a code or a comment-header?
app
library(teal)

ADSL <- scda::synthetic_cdisc_data("latest")$adsl
ADTTE <- scda::synthetic_cdisc_data("latest")$adtte
ADRS <- scda::synthetic_cdisc_data("latest")$adrs

data <- teal_data(ADSL = ADSL, ADTTE = ADTTE, ADRS = ADRS)

app <- init(
  data = data,
  modules = list(
    example_module()
  )
  # filter = default_filters
)


runApp(app)

Code of Conduct

  • I agree to follow this project's Code of Conduct.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines.

Security Policy

  • I agree to follow this project's Security Policy.
@gogonzo gogonzo added the enhancement New feature or request label Sep 26, 2024
@vedhav
Copy link
Contributor

vedhav commented Sep 26, 2024

display yellow warning in show R code?

I like the idea of displaying a yellow warning in the show R code. Ideally it can live in teal.widgets which is used for showing R code but teal.widgets does not import teal.data and teal.code. This makes me wonder if this feature should be in teal instead. Of course we can send this information to the UI generator from the modules. But I think users should not pass this information.
We also have bslib tooltips and popovers which can help in providing some text on hovering some info when this happens.

append warning message in a code or a comment-header?

We already append the warning on the code copy block, were you thinking of showing this somewhere outside which is more visible? Say, creating a div at the top of the teal app that shows this warning?

@gogonzo
Copy link
Contributor Author

gogonzo commented Sep 26, 2024

We already append the warning on the code copy block

We don't do this anymore. warning caused some headache in teal see the discussion. I don't suggest any solution yet, I think we need to discuss this complexly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants