Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] steps_per_second under-reporting in SAC and IQL #1078

Open
JemmaLDaniel opened this issue May 13, 2024 · 0 comments
Open

[BUG] steps_per_second under-reporting in SAC and IQL #1078

JemmaLDaniel opened this issue May 13, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@JemmaLDaniel
Copy link
Contributor

Describe the bug

The (originally combined) steps_per_second logging has been separated for now to enforce logging consistencies across Mava systems, enabling downstream aggregate plotting via marl-eval. However, the current steps_per_second logging in the IQL and SAC systems is not a true representation for the learner or the actor. It is not entirely fair to say that we do steps_per_rollout / elapsed _time steps per second in both cases because we are also taking anakin_steps * cfg.system.epochs gradient steps.
@JemmaLDaniel JemmaLDaniel added the bug Something isn't working label May 13, 2024
@sash-a sash-a added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sash-a @JemmaLDaniel