Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTAIN] Better equality check for jaxmarl specs #961

Open
sash-a opened this issue Dec 7, 2023 · 0 comments
Open

[MAINTAIN] Better equality check for jaxmarl specs #961

sash-a opened this issue Dec 7, 2023 · 0 comments
Labels
maintenance General improvements/optimisations

Comments

@sash-a
Copy link
Contributor

sash-a commented Dec 7, 2023

Please describe what needs to be maintained?

This came up in #955. Unfortunately it's quite messy to check the equality of two jaxmarl spaces as they don't have custom __eq__ methods. So the current solution is to check that only the shapes match. This could cause possible bugs in the future so it would be great to find a better solution.

@sash-a sash-a added the maintenance General improvements/optimisations label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General improvements/optimisations
Projects
None yet
Development

No branches or pull requests

1 participant