Skip to content

Commit 8fdead2

Browse files
committed
Initial thoughts on 4.x upgrade
1 parent 9b63e56 commit 8fdead2

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

lib/Pdfjs.4.x.upgrade.MD

+14
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
Let's leave sample app for now. It is easy to rewrite from scratch.
2+
Let's leave live demo as well. Plan is to rewrite.
3+
4+
- Why was ng-packagr added as dev dependency ?
5+
- Assuming shx works on windows as well. New to this.
6+
- PDF's are loaded inside an iframe. Does document.addEventListner() gets fired even if we use iframe?
7+
There are two scenarios. PDF can be embedded in html or opened in a new window.
8+
- I like the way pdfjs's event bus is used. In the beginning I had to hack pdfjs library pdfjs library to send those browser events. :-)
9+
10+
11+
12+
Thought for community - How about starting a discord server for ng2-pdfjs-viewer ?
13+
14+

0 commit comments

Comments
 (0)