Skip to content

Commit 67bbc2a

Browse files
committed
Review comments
1 parent 6eccbcd commit 67bbc2a

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

sycl/include/sycl/queue.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -219,10 +219,10 @@ auto submit_kernel_direct_parallel_for(
219219
template <typename KernelName = detail::auto_name, bool EventNeeded = false,
220220
typename PropertiesT, typename KernelTypeUniversalRef>
221221
auto submit_kernel_direct_single_task(
222-
const queue &Queue, PropertiesT Props, KernelTypeUniversalRef &&KernelFunc,
222+
const queue &Queue, [[maybe_unused]] PropertiesT Props,
223+
KernelTypeUniversalRef &&KernelFunc,
223224
const detail::code_location &CodeLoc = detail::code_location::current()) {
224225
// TODO Properties not supported yet
225-
(void)Props;
226226
static_assert(
227227
std::is_same_v<PropertiesT,
228228
ext::oneapi::experimental::empty_properties_t>,
@@ -244,7 +244,7 @@ auto submit_kernel_direct_single_task(
244244
// Instantiating the kernel on the host improves debugging.
245245
// Passing this pointer to another translation unit prevents optimization.
246246
#ifndef NDEBUG
247-
// TODO: call library to prevent dropping call due to optimization
247+
// TODO: call library to prevent dropping call due to optimization.
248248
(void)detail::GetInstantiateKernelOnHostPtr<KernelType, void, 1>();
249249
#endif
250250

sycl/test-e2e/Basic/test_num_kernel_copies.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ int main(int argc, char **argv) {
3636

3737
kernel<2> krn2;
3838
q.single_task(krn2);
39-
// The kernel is copied on the scheduler-based path only
39+
// The kernel is copied on the scheduler-based path only.
4040
assert(copy_count == 0);
4141
assert(move_count == 0);
4242
copy_count = 0;

0 commit comments

Comments
 (0)