[clang][Driver][SYCL] Disable SYCL header search paths under -nostd[lib]inc
#20583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
| // those STL headers in their programs (e.g., <complex>). | ||
| SmallString<128> STLWrappersDir(SYCLDir); | ||
| llvm::sys::path::append(STLWrappersDir, "stl_wrappers"); | ||
| // Add the SYCL specific header directories as system directories for non |
Contributor
There was a problem hiding this comment.
I understand that you have retained the comments from the original code, but could you add some context on why SYCL specific header directories are added as system directories for non MSVC compilers?
Contributor
Author
There was a problem hiding this comment.
That should go into a separate PR, possibly merging the implementation of host/device toolchains.
srividya-sundaram
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That matches the intended behavior of those options.