Skip to content

Commit fb0f6c6

Browse files
authored
[WebNN] Fix bug in Float16Array availability check (microsoft#25354)
The `from` is not a property of `Float16Array` but an inherited function, we can use `Float16Array['from']` to check if it is available.
1 parent 57c9743 commit fb0f6c6

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

onnxruntime/core/providers/webnn/builders/impl/rotaryEmbedding_op_builder.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ Status RotaryEmbeddingOpBuilder::AddToModelBuilderImpl(ModelBuilder& model_build
285285
sign_buffer.set(1, 1.0f);
286286
} else if (input_data_type == ONNX_NAMESPACE::TensorProto_DataType_FLOAT16) {
287287
if (model_builder.IsFloat16ArrayAvailable()) {
288-
// Float16Array is avaliable - use Float16Array.
288+
// Float16Array is available - use Float16Array.
289289
sign_buffer = emscripten::val::global("Float16Array").new_(2);
290290
sign_buffer.set(0, -1.0f);
291291
sign_buffer.set(1, 1.0f);

onnxruntime/core/providers/webnn/builders/model_builder.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ class ModelBuilder {
7878
const GraphViewer& graph_viewer_;
7979
const logging::Logger& logger_;
8080
const bool is_float16array_available_ = !emscripten::val::global("Float16Array").isUndefined() &&
81-
emscripten::val::global("Float16Array").hasOwnProperty("from");
81+
!emscripten::val::global("Float16Array")["from"].isUndefined();
8282

8383
emscripten::val wnn_context_ = emscripten::val::undefined();
8484
emscripten::val wnn_builder_ = emscripten::val::undefined();

0 commit comments

Comments
 (0)