Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More complete support for signed operations #77

Open
mkorbel1 opened this issue Jan 14, 2022 · 3 comments
Open

More complete support for signed operations #77

mkorbel1 opened this issue Jan 14, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@mkorbel1
Copy link
Contributor

Motivation

Right now most operations in ROHD are unsigned. Less than, greater than, etc. would be a lot more convenient with some built in signed support.

Desired solution

Allow operations to be performed using signed or unsigned math optionally.

Alternatives considered

Letting users do their own signed math is unnecessary overhead.
@mkorbel1 mkorbel1 added the enhancement New feature or request label Jan 14, 2022
@mkorbel1
Copy link
Contributor Author

Needs extensive testing as well, obviously

@mkorbel1
Copy link
Contributor Author

mkorbel1 commented Jun 8, 2022

This also needs to consider things like toInt and toBigInt for LogicValue. Currently, if you have a 64-bit LogicValue, then the resulting toInt is signed, but if it's less then that it won't be signed because upper bits are zero. A consistent solution should be provided for all sign-related features, including these functions.

@samimia-swks
Copy link

I imagine this is a pre-requisite to #470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkorbel1 @samimia-swks