Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis.yml for MacOS tried to update documentation #196

Open
mcr opened this issue Jan 23, 2021 · 1 comment
Open

travis.yml for MacOS tried to update documentation #196

mcr opened this issue Jan 23, 2021 · 1 comment

Comments

@mcr
Copy link
Contributor

mcr commented Jan 23, 2021

The travis.yml executes ./scripts/update-docs.sh.
I think that this should have a guard such that it runs only when within the primary tinycbor repository and/or it should be followed by || exit 0, as I don't think failure to update the docs should be a cause for the regression tests to fail.

It also seems to fail for macOS build only. Maybe because the listed code sizes changes on macOS only, so that's the only case where the docs need to be updated.

I can send a PR, if you advise how you think you want this fixed.

@thiagomacieira
Copy link
Member

It should indeed || exit 0 at least. I've seen this error more than once and I just ignored it by rebuilding. The other thing is that the git push of code sizes can fail too, if more than one builder is trying to push changes at the same time (FF errors).

I'll appreciate a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants