Basic workers stats #148
Open
Basic workers stats #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ show uuids metrics query in debug log
- (porto) cpu load calculation - remove redundant slice make - rename container metrics -> worker metrics - rename gatherLoop -> gatherMetricsEvery
dkarpukhin
reviewed
Jan 16, 2018
| return nil, err | ||
| } | ||
|
|
||
| return d.onWorkersMetrics(uuids) |
There was a problem hiding this comment.
are u sure that not
return d.onWorkersMetrics(uuids), nil
?
antmat
reviewed
Jan 17, 2018
isolate/initialdispatch.go
Outdated
|
|
||
| sz, err = r.ReadArrayHeader() | ||
| if err != nil { | ||
| return uuids, err |
| return nil, err | ||
| } | ||
|
|
||
| return d.onWorkersMetrics(uuids) |
|
|
||
| startTime := time.Now() | ||
|
|
||
| sendMetricsFunc := func(metrics MetricsResponse) { |
There was a problem hiding this comment.
Maybe better to make as a standalone function or method?
isolate/initialdispatch.go
Outdated
| ) | ||
|
|
||
| if d == nil { | ||
| log.G(d.ctx).Error("strange: dispatch is `nil`") |
There was a problem hiding this comment.
can it happen? If no - maybe remove, so we can get a crash when logic is being somehow violated?
isolate/porto/metrics_gatherer.go
Outdated
| select { | ||
| case <- ctx.Done(): | ||
| return | ||
| case <-time.After(interval): |
There was a problem hiding this comment.
maybe it' better to use time.Ticker it should spawn less goroutines
karitra
force-pushed
the
per_worker_stat
branch
2 times, most recently
from
4a493a3 to
e19d3a7
Compare
karitra
force-pushed
the
per_worker_stat
branch
from
e19d3a7 to
7632da4
Compare
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
- Coverage 35.98% 28.93% -7.05%
==========================================
Files 41 45 +4
Lines 3185 3981 +796
==========================================
+ Hits 1146 1152 +6
- Misses 1758 2548 +790
Partials 281 281
Continue to review full report at Codecov.
|
karitra
force-pushed
the
per_worker_stat
branch
from
c545557 to
e9a0441
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For preliminary review.
Gopher gurus, @3Hren, @antmat, PTAL.
Metrics (for porto and procfs):
Setup (via config file)
Zero poll period (default) switches metrics poll off.
TODO: