Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance monitoring for each PR #3240

Open
2 tasks
golobitch opened this issue Jan 25, 2025 · 0 comments · May be fixed by #3274
Open
2 tasks

Add performance monitoring for each PR #3240

golobitch opened this issue Jan 25, 2025 · 0 comments · May be fixed by #3274
Assignees

Comments

@golobitch
Copy link
Collaborator

To ensure that performance does not degrade with new changes, we should add performance monitoring to the CI pipeline. The goal is to run a performance script with each PR and report the results directly in the PR as a comment. If the TPS metric fails below a threshold (eg 5 TPS) the build should fail

Context

  • Performance should be monitored continuously to maintain quality
  • Initial implementation could use a k6 script to measure and report performance metrics such as req/s and iter/s
  • Fetching the TPS metric directly from Prometheus is worth exploring but might be more involved

Acceptance Criteria

  • Add a k6 performance script to the CI pipeline
  • Execute the script for every PR and print the results as a comment in PR

Tasks

  • integrate the performance script into the CI pipeline and ensure it runs with each PR
  • add logic to post the script results as a comment in the PR
@golobitch golobitch added the discussions: ideas Convert to an idea discussion label Jan 25, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Rafiki Jan 25, 2025
@mkurapov mkurapov moved this from Backlog to Todo in Rafiki Feb 4, 2025
@mkurapov mkurapov moved this from Todo to Backlog in Rafiki Feb 4, 2025
@mkurapov mkurapov moved this from Backlog to Todo in Rafiki Feb 4, 2025
@mkurapov mkurapov removed the discussions: ideas Convert to an idea discussion label Feb 5, 2025
@BlairCurrey BlairCurrey linked a pull request Feb 5, 2025 that will close this issue
6 tasks
@mkurapov mkurapov moved this from Todo to In Progress in Rafiki Feb 7, 2025
@mkurapov mkurapov moved this from In Progress to Ready for Review in Rafiki Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for Review
Development

Successfully merging a pull request may close this issue.

3 participants