Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Multi-Tenant] Wallet address prefixes #3278

Open
2 tasks
mkurapov opened this issue Feb 7, 2025 · 0 comments
Open
2 tasks

[Multi-Tenant] Wallet address prefixes #3278

mkurapov opened this issue Feb 7, 2025 · 0 comments
Assignees
@golobitch
Milestone
Multi Tenant v1

Comments

@mkurapov
Copy link
Contributor

mkurapov commented Feb 7, 2025 •
edited
Loading

Context

Each tenant should have a setting for which wallet address prefix they are allowed to use. For example, in the context of JOPACC, an example would be:

Bank 1 (Tenant 1):
Prefix/range: https://jopacc.com/arabbank/
https://jopacc.com/arabbank/<user>

Bank 2 (Tenant 2):
Prefix/range: https://jopacc.com/abcbank/
https://jopacc.com/abcbank/<user>

If a tenant tries to create a wallet address with the incorrect "prefix" or "range", then we should throw an error.
We should store this prefix/range in the tenant settings.

During wallet address creation, we should check whether the non-operator tenant is trying to create a wallet address with the correct URL. Be wary of slashes.

Todos

  • Allow configuring a wallet address prefix or range via tenant settings
  • Check the wallet address prefix during wallet address creation
@github-project-automation github-project-automation bot moved this to Backlog in Rafiki Feb 7, 2025
@mkurapov mkurapov changed the title Wallet address ranges [Multi-Tenant] Wallet address ranges Feb 7, 2025
@mkurapov mkurapov changed the title [Multi-Tenant] Wallet address ranges [Multi-Tenant] Wallet address prefixes Feb 7, 2025
@mkurapov mkurapov moved this from Backlog to Todo in Rafiki Feb 18, 2025
@golobitch golobitch added this to the Multi Tenant v1 milestone Feb 25, 2025
golobitch added a commit that referenced this issue Mar 1, 2025
@golobitch
feat(wallet-address): replace url field with address field
eeb1f4c 
url field was replaced with address field, because now with range in wallet address, it is possible
for the caller, to specify just the portion of the wallet address url. There is no need to specify
the whole url in order to create wallet address.

#3278
@golobitch golobitch mentioned this issue Mar 1, 2025
Draft
6 tasks
@mkurapov mkurapov moved this from Todo to In Progress in Rafiki Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@golobitch golobitch

Labels
None yet
Projects
Rafiki
Status: In Progress
Milestone
Multi Tenant v1
Development

No branches or pull requests
2 participants
@mkurapov @golobitch