feat: bring asset response type into shared package (#1361)

* - Bring asset response type into shared package

* Fix import assets

* Fix import assets

* implemented shared asset response types

* bring rate response in separated file
change response names

* bring rate response in separated file
change response names

* fix ci

* fix ci

* fix ci

Author: domin191013

.github/workflows/ci.yml

@@ -73,7 +73,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: ./.github/workflows/setup
-      - run: pnpm wallet:backend test --detectOpenHandles --forceExit
+      - run: pnpm wallet:backend build && pnpm wallet:backend test --detectOpenHandles --forceExit
 
   test-boutique-backend:
     name: BOUTIQUE - Test backend

packages/wallet/backend/package.json

@@ -2,7 +2,7 @@
   "name": "@wallet/backend",
   "scripts": {
     "start": "node -r tsconfig-paths/register dist/index.js",
-    "build:deps": "pnpm --filter @shared/backend build",
+    "build:deps": "pnpm --filter @shared/backend build && pnpm --filter @wallet/shared build",
     "build": "pnpm build:deps && tsc --build tsconfig.build.json && tsc-alias -p tsconfig.build.json",
     "test": "jest --passWithNoTests --maxWorkers=75%",
     "generate": "graphql-codegen --config codegen.yml"
@@ -11,6 +11,7 @@
     "@google-cloud/logging-winston": "^6.0.0",
     "@sendgrid/mail": "^8.1.3",
     "@shared/backend": "workspace:*",
+    "@wallet/shared": "workspace:*",
     "awilix": "^10.0.2",
     "axios": "^1.7.2",
     "cors": "^2.8.5",

packages/wallet/backend/src/asset/controller.ts

@@ -1,18 +1,18 @@
 import { NextFunction, Request } from 'express'
-import { Asset } from '@/rafiki/backend/generated/graphql'
 import { RafikiClient } from '@/rafiki/rafiki-client'
 import { Controller, toSuccessResponse } from '@shared/backend'
+import { AssetResponse } from '@wallet/shared'
 
 interface IAssetController {
-  list: Controller<Asset[]>
+  list: Controller<AssetResponse[]>
 }
 
 export class AssetController implements IAssetController {
   constructor(private rafikiClient: RafikiClient) {}
 
   list = async (
     _req: Request,
-    res: CustomResponse<Asset[]>,
+    res: CustomResponse<AssetResponse[]>,
     next: NextFunction
   ) => {
     try {

packages/wallet/backend/src/rafiki/controller.ts

@@ -1,9 +1,10 @@
 import { NextFunction, Request, Response } from 'express'
 import { Logger } from 'winston'
-import { RatesResponse, RatesService } from '@/rates/service'
+import { RatesService } from '@/rates/service'
 import { validate } from '@/shared/validate'
 import { RafikiService } from './service'
 import { ratesSchema, webhookSchema } from './validation'
+import { RatesResponse } from '@wallet/shared'
 
 interface IRafikiController {
   getRates: (

packages/wallet/backend/src/rates/service.ts

@@ -1,11 +1,7 @@
 import axios from 'axios'
 import NodeCache from 'node-cache'
 import { Env } from '@/config/env'
-
-export type RatesResponse = {
-  base: string
-  rates: Record<string, number>
-}
+import { RatesResponse } from '@wallet/shared'
 
 export interface IRatesService {
   getRates: (base: string) => Promise<RatesResponse>

packages/wallet/frontend/src/components/ExchangeRate.tsx

@@ -1,7 +1,7 @@
-import { AssetOP, ExchangeRates } from '@/lib/api/asset'
 import { getCurrencySymbol } from '@/utils/helpers'
 import { memo } from 'react'
 import { SimpleArrow } from './icons/Arrow'
+import { AssetOP, ExchangeRates } from '@/lib/api/asset'
 
 type ExchangeRateProps = {
   convertAmount: number

packages/wallet/frontend/src/components/dialogs/FundAccountDialog.tsx

@@ -11,7 +11,7 @@ import { useZodForm } from '@/lib/hooks/useZodForm'
 import { Form } from '@/ui/forms/Form'
 import { useRouter } from 'next/router'
 import { useOnboardingContext } from '@/lib/context/onboarding'
-import { fundAccountSchema } from '@wallet/shared/src/responses'
+import { fundAccountSchema } from '@wallet/shared'
 
 type FundAccountDialogProps = Pick<DialogProps, 'onClose'> & {
   account: Account

packages/wallet/frontend/src/components/dialogs/WithdrawFundsDialog.tsx

@@ -10,7 +10,7 @@ import { getCurrencySymbol, getObjectKeys } from '@/utils/helpers'
 import { useZodForm } from '@/lib/hooks/useZodForm'
 import { Form } from '@/ui/forms/Form'
 import { useRouter } from 'next/router'
-import { withdrawFundsSchema } from '@wallet/shared/src/responses'
+import { withdrawFundsSchema } from '@wallet/shared'
 
 type WithdrawFundsDialogProps = Pick<DialogProps, 'onClose'> & {
   account: Account

packages/wallet/frontend/src/lib/api/account.ts

@@ -9,10 +9,10 @@ import { acceptQuoteSchema, Quote } from './transfers'
 import { WalletAddress } from './walletAddress'
 import {
   createAccountSchema,
-  exchangeAssetSchema,
   fundAccountSchema,
-  withdrawFundsSchema
-} from '@wallet/shared/src/responses'
+  withdrawFundsSchema,
+  exchangeAssetSchema
+} from '@wallet/shared'
 
 export type Account = {
   id: string

packages/wallet/frontend/src/lib/api/asset.ts

@@ -4,29 +4,18 @@ import {
   httpClient,
   type SuccessResponse
 } from '../httpClient'
-
-export type Asset = {
-  id: string
-  code: string
-  scale: number
-  withdrawalThreshold?: bigint
-  createdAt: string
-}
-
-export type Rates = {
-  base: string
-  rates: Record<string, number>
-}
+import { AssetResponse, RatesResponse } from '@wallet/shared'
 
 export type AssetOP = {
   assetCode: string
   assetScale: number
 }
 
-type ListAssetsResult = SuccessResponse<Asset[]>
+export type ExchangeRates = Record<string, number>
+
+type ListAssetsResult = SuccessResponse<AssetResponse[]>
 type ListAssetsResponse = ListAssetsResult | ErrorResponse
 
-export type ExchangeRates = Record<string, number>
 type GetExchangeRatesResponse = SuccessResponse<ExchangeRates> | ErrorResponse
 
 interface AssetService {
@@ -54,7 +43,7 @@ const createAssetService = (): AssetService => ({
     try {
       const response = await httpClient
         .get(`rates?base=${assetCode}`)
-        .json<Rates>()
+        .json<RatesResponse>()
 
       const rates = {
         [response.base]: 1,