Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint checks in CI and update ESLint to next major version #298

Open
1 of 2 tasks
raducristianpopa opened this issue Jun 4, 2024 · 3 comments
Open
1 of 2 tasks

Comments

@raducristianpopa
Copy link
Member

raducristianpopa commented Jun 4, 2024

We currently do not have lint checks in CI and this is breaking the current ESLint scripts.

Originally posted by @raducristianpopa in #297 (comment)

@sidvishnoi
Copy link
Member

Ok the eslint ecosystem isn't ready yet for upgrade. We can write more code to make it work, but not worth it. I tried, and failed.
We'll get enough unmet peer dependencies warnings, and the legacy/compat packages don't work too well together - missing warnings, false positives.
For migration, I used https://eslint.org/blog/2024/05/eslint-configuration-migrator/, it was helpful, but still missing warnings.

So, let's keep it in backlog.

@sidvishnoi
Copy link
Member

Update: All plugins except following now support eslint v9:

typescript-eslint v8 (presently in beta) supports v9.

├─┬ eslint-plugin-jest 28.6.0
│ ├── ✕ unmet peer @typescript-eslint/eslint-plugin@"^6.0.0 || ^7.0.0": found 8.0.0-alpha.30
│ └─┬ @typescript-eslint/utils 7.13.0
│   └── ✕ unmet peer eslint@^8.56.0: found 9.5.0
├─┬ eslint-plugin-jsx-a11y 6.9.0
│ └── ✕ unmet peer eslint@"^3 || ^4 || ^5 || ^6 || ^7 || ^8": found 9.5.0
├─┬ eslint-plugin-react 7.34.3
│ └── ✕ unmet peer eslint@"^3 || ^4 || ^5 || ^6 || ^7 || ^8": found 9.5.0
├─┬ eslint-plugin-react-hooks 4.6.2
│ └── ✕ unmet peer eslint@"^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0-0": found 9.5.0

@sidvishnoi
Copy link
Member

As of Aug 21:

├─┬ eslint-plugin-jest 28.8.0
│ └─┬ @typescript-eslint/utils 7.16.0
│   └── ✕ unmet peer eslint@^8.56.0: found 9.9.0
├─┬ eslint-plugin-jsx-a11y 6.9.0
│ └── ✕ unmet peer eslint@"^3 || ^4 || ^5 || ^6 || ^7 || ^8": found 9.9.0
├─┬ eslint-plugin-react-hooks 4.6.2
│ └── ✕ unmet peer eslint@"^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0-0": found 9.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Blocked
Development

No branches or pull requests

2 participants