Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Replace copy/paste of public key with URL parameter to wallet provider #311

Open
jeremiahlee opened this issue Jun 6, 2024 · 1 comment
Labels
discussion: idea Ideas of potential features triage Waiting to be assigned labels
Milestone

Comments

@jeremiahlee
Copy link

jeremiahlee commented Jun 6, 2024

Describe the feature you would like to request

I would like the extension onboard to have fewer steps the user must complete.

In the alpha 1 release, the user must copy a public key from the extension and paste it into the wallet provider's website.

2024-05-30.alpha1.clip.share.mp4

Describe the solution you would like

  1. User enters wallet address and taps connect.
  2. Extension opens the wallet provider's website with the extension's public key as a URL parameter.
  3. Wallet provider authenticates the user and saves the extension's public key when the user confirms they want to authorize the amount to use from the wallet.

Additional context

I'm not sure if additional information can be passed along with the grant approval. If not, then the desired solution would be to first confirm the user wants to use this browser for Web Monetization (as a way to approve saving the public key) and then the grant approval for the budget is a second approval.

While Interledger does not control the wallet provider website, but it could define a URI scheme as part of the wallet provider specification. Something like https:// (walletProvider.example/usersWalletAddress) /keys/add?key= (public key contents here). Because the key is a public key, it's fine for it to be passed as a URL parameter, where it might be included in server access logs.

@jeremiahlee jeremiahlee added triage Waiting to be assigned labels discussion: idea Ideas of potential features labels Jun 6, 2024
@tselit tselit added this to the Backlog milestone Jun 20, 2024
@sidvishnoi
Copy link
Member

Some related discussion in #332 also (but about removing keys, not adding).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion: idea Ideas of potential features triage Waiting to be assigned labels
Projects
Status: Backlog
Development

No branches or pull requests

3 participants