Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify monetization link detection and handling #920

Open
DarianM opened this issue Feb 13, 2025 · 0 comments · May be fixed by #922
Open

Simplify monetization link detection and handling #920

DarianM opened this issue Feb 13, 2025 · 0 comments · May be fixed by #922
Assignees
@DarianM
Labels
area: content Improvements or additions to extension content script

Comments

@DarianM
Copy link
Member

DarianM commented Feb 13, 2025 •
edited
Loading

  • instead of searching every added or removed node using the mutation observer, use the same observer to search the entire window / first level iframes document every time an element gets added
  • make use of existing getMonetizationLinkTags logic that searches for link tangs inside documents and build around it

part of #842
@DarianM DarianM linked a pull request Feb 13, 2025 that will close this issue
Open
@DarianM DarianM linked a pull request Feb 13, 2025 that will close this issue
fix(MonetizationLinkManager): simplify search, get first link from iframe #922
Open
@sidvishnoi sidvishnoi moved this from Backlog to In Progress in Web Monetization Extension Feb 21, 2025
@sidvishnoi sidvishnoi added the area: content Improvements or additions to extension content script label Feb 24, 2025
@DarianM DarianM moved this from In Progress to In Review in Web Monetization Extension Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DarianM DarianM

Labels
area: content Improvements or additions to extension content script
Projects
Web Monetization Extension
Status: In Review
Milestone
No milestone
2 participants
@sidvishnoi @DarianM