Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topology_rest_server_stop handler #2

Open
konstantinos-papadopoulos opened this issue Jan 20, 2016 · 2 comments
Open

topology_rest_server_stop handler #2

konstantinos-papadopoulos opened this issue Jan 20, 2016 · 2 comments

Comments

@konstantinos-papadopoulos
Copy link
Member

To be consistent with Multinet a conf key "topology_rest_server_stop" has been added which is not used at the moment when mininet is used as a generator. However, the mininet rest server stop takes place through stop_mininet_server() under mininet_utils.py. In Multinet this action is done by cleanup handler under /bin. I think we should be consistent in both cases since NSTAT treats both mininet and multinet as southbound generators. @panageo What do you think?

@panageo
Copy link
Member

panageo commented Jan 20, 2016

Mininet did not have a stop handler.

We could either create one and use it in mininet_utils or omit this
parameter for mininet tests. You are right for consistency reasons we
should create a stop handler and use it.

Best regards

On Wed, Jan 20, 2016 at 3:13 PM, Konstantinos Papadopoulos <
[email protected]> wrote:

To be consistent with Multinet a conf key "topology_rest_server_stop" has
been added which is not used at the moment when mininet is used as a
generator. However, the mininet rest server stop takes place through
stop_mininet_server() under mininet_utils.py. In Multinet this actions is
done by cleanup handler under /bin. I think we should be consistent in both
cases since NSTA treats both mininet and multinet as southbound generators.
@panageo https://github.com/panageo What do you think?


Reply to this email directly or view it on GitHub
#2.

@konstantinos-papadopoulos
Copy link
Member Author

At the moment conf key "topology_rest_server_stop" within sample json files

  • lithium_nb_active_scalability_mininet.json
  • lithium_sb_idle_scalability_mininet.json

is cheated with the value './topology_custom_boot.py' which is not used at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants