Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in CoreConstants.php #409

Open
gmariani opened this issue Jul 4, 2021 · 8 comments · May be fixed by #411
Open

Typo in CoreConstants.php #409

gmariani opened this issue Jul 4, 2021 · 8 comments · May be fixed by #411

Comments

@gmariani
Copy link

gmariani commented Jul 4, 2021 

    /**
     * Current QuickBooks Namespace for PHP SDK
     * @var int Deflate
     */
    const NAMEPSACE_DATA_PREFIX = 'QuickBooksOnline\\API\\Data\\';

NAMEPSACE_DATA_PREFIX should be NAMESPACE_DATA_PREFIX
@yashasvimisra2798
Copy link

Hey, I would like to work on this issue please assign this to me.

@yashasvimisra2798 yashasvimisra2798 linked a pull request Jul 16, 2021 that will close this issue
Open
@yashasvimisra2798
Copy link

@gmariani I have raised a PR fixing this issue, please check.
Thank you!

@gmariani
Copy link
Author

Looks like this constant is also used in:
src/XSD2PHP/src/com/mikebevz/xsd2php/Bind.php
src/Core/Http/Serialization/XmlObjectSerializer.php
src/Utility/MetadataExtractor.php
src/Facades/FacadeHelper.php

Just changing src/Core/CoreConstants.php will cause the rest of the files/classes to break.

@yashasvimisra2798
Copy link

Shall I make changes to these files as well?

@gmariani
Copy link
Author

Only if you don't want to break the SDK. lol

@yashasvimisra2798
Copy link

Hey @gmariani I have raised a PR with the said changes, please guide me if anything else needs to be done

@yashasvimisra2798
Copy link

Are there any more changes to be done in the PR #411?

@gmariani
Copy link
Author

gmariani commented Aug 6, 2021

Not that i know of, i have not tested this. I was just reporting the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Typo yashasvimisra2798/QuickBooks-V3-PHP-SDK
2 participants
@gmariani @yashasvimisra2798