Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation Does Not Match QuickBooksOnline\API\DataService\Batch::AddQuery() signature #417

Open
ajgale opened this issue Aug 16, 2021 · 1 comment · May be fixed by #418
Open

Documentation Does Not Match QuickBooksOnline\API\DataService\Batch::AddQuery() signature #417

ajgale opened this issue Aug 16, 2021 · 1 comment · May be fixed by #418

Comments

@ajgale
Copy link

ajgale commented Aug 16, 2021

https://developer.intuit.com/app/developer/qbo/docs/develop/sdks-and-samples-collections/php/synchronous-calls#batch-process

The following example code from the above link is incorrect:
$batch->AddQuery("select * from Customer startPosition 0 maxResults 20", "queryCustomer", "uniqueQuery");

AddQuery takes 2 parameters:

    /**
     * Adds the specified query.
     * @param string $query IDS query.
     * @param string $id unique batchitem id.
     */
    public function AddQuery($query, $id)
@ajgale ajgale linked a pull request Aug 16, 2021 that will close this issue
Open
@ajgale
Copy link
Author

ajgale commented Aug 16, 2021

Submitted PR only fixes examples in this repo. It doesn't look like the linked documentation is generated from those files, so at the moment I believe this is all I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update AddQuery examples to match function signature ajgale/QuickBooks-V3-PHP-SDK
1 participant
@ajgale