Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code to align to ES6 syntax #22

Open
nsinghal12 opened this issue Oct 14, 2022 · 4 comments
Open

Refactor code to align to ES6 syntax #22

nsinghal12 opened this issue Oct 14, 2022 · 4 comments
Assignees
Milestone

Comments

@nsinghal12
Copy link
Collaborator

No description provided.

@Amor64
Copy link

Amor64 commented Oct 15, 2022

@nsinghal12 could you please assign this task to me.

@Amor64
Copy link

Amor64 commented Oct 15, 2022

@nsinghal12 could you also elaborate the problem statement with identified places where ES6 code refactor desired or will this task also include identifying the places where code factor for ES6 is required & made the changes accordingly ?

@nsinghal12
Copy link
Collaborator Author

Hi @Amor64 - the task involves

  • change Promises to use async/await
  • change var to const

This task does not involve changing or removing callback.

@Amor64
Copy link

Amor64 commented Oct 18, 2022

Thanks for the input @nsinghal12 , will work on it.

Amor64 pushed a commit to Amor64/node-pom-parser that referenced this issue Oct 21, 2022
Amor64 pushed a commit to Amor64/node-pom-parser that referenced this issue Oct 21, 2022
Amor64 pushed a commit to Amor64/node-pom-parser that referenced this issue Oct 26, 2022
Amor64 pushed a commit to Amor64/node-pom-parser that referenced this issue Oct 26, 2022
Amor64 pushed a commit to Amor64/node-pom-parser that referenced this issue Oct 27, 2022
@nsinghal12 nsinghal12 added this to the 2.0.0 milestone Oct 28, 2022
Amor64 pushed a commit to Amor64/node-pom-parser that referenced this issue Nov 10, 2022
Amor64 pushed a commit to Amor64/node-pom-parser that referenced this issue Nov 10, 2022
Amor64 pushed a commit to Amor64/node-pom-parser that referenced this issue Nov 10, 2022
Amor64 pushed a commit to Amor64/node-pom-parser that referenced this issue Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants