-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New production ready Helm chart #1224
base: main
Are you sure you want to change the base?
Conversation
Definitely it is a good idea to use non-root user in the containers. I'll provide a PR for that. |
Great ! Also, read-only filesystem can be nice to use. |
Another thing I thinked about, that's using a GitHub Action to bump chart version and change appVersion when a new tag is made. Like that, we don't need to set manually the image tag version when upgrading. I don't know too much about GH Actions but I found that : https://github.com/shini4i/helm-charts-updater |
21644ee
to
93115ea
Compare
@ab-smith @eric-intuitem Chart seems done. Need a review (and some tests on your side if possible). I didn't added the GitHub Actions to generate and publish the chart, if you can check to add it, it can be nice (see the previous comment) |
we'll need to explicitly mention the @Nathanael-Mtd : how is it supposed to behave? user should install pg using specific values/settings first or it will be installed automatically as a dependency? side note: helm has an annoying limitation, that can interfere with this, on |
@ab-smith Warning fixed. I added a templating file to add custom instructions to install the chart from official helm chart repo (I supposed it will be To test the build and push of the helm chart, you can use these commands :
But I think you can find an existing GH Action which can handle the release with these steps. |
After discussions in #1216, I made a new "next" Helm Chart with more options to have more flexibility in Kubernetes deployments.
Many changes in comparaison of the current chart, need some reviews.
Current features progress in this new chart: